[jira] [Commented] (KAFKA-2588) ReplicaManager partitionCount metric should actually be replicaCount

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933448#comment-14933448 ] 

ASF GitHub Bot commented on KAFKA-2588:
---------------------------------------

GitHub user granthenke opened a pull request:

    https://github.com/apache/kafka/pull/254

    KAFKA-2588 ReplicaManager partitionCount metric should actually be re…

    …plicaCount

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/granthenke/kafka partition-metric

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #254
    
----
commit 9ba94394ce90dd4903f356b19a967339e00aee57
Author: Grant Henke <gr...@gmail.com>
Date:   2015-09-28T15:32:02Z

    KAFKA-2588 ReplicaManager partitionCount metric should actually be replicaCount

----


> ReplicaManager partitionCount metric should actually be replicaCount
> --------------------------------------------------------------------
>
>                 Key: KAFKA-2588
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2588
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.2.1
>            Reporter: Grant Henke
>            Assignee: Grant Henke
>
> The metrics "partitionCount" in the ReplicaManager actually represents the count of replicas. 
> As an example if I have a cluster with 1 topic with 1 partitions and a replication factor of 3. The metric (aggregated) would show a value of 3. 
> There is a metric called "LeaderCount" that actually represents the "partitionCount". In my example above the metric (aggregated) would show a value of 1. 
> We do need to consider compatibility of consuming systems. I think the most simple change would be to:
> - Adjust the "partitionCount" metric to be the same value as "LeaderCount"
> - Add a "replicaCount" metric which contains the values "partitionCount" does today
> - Leave "LeaderCount" in for compatibility
> Documentation will need to be updated as well. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)