You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/01 09:59:02 UTC

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #2399: chore: use json schema instead hard code

starsz commented on a change in pull request #2399:
URL: https://github.com/apache/apisix-dashboard/pull/2399#discussion_r840425803



##########
File path: api/internal/core/store/storehub.go
##########
@@ -57,6 +57,19 @@ func InitStore(key HubKey, opt GenericStoreOption) error {
 		HubKeyGlobalRule:  true,
 		HubKeyStreamRoute: true,
 	}
+
+	hubsNeedCheckByCustomize := map[HubKey]bool{
+		HubKeySystemConfig: true,
+	}
+
+	if _, ok := hubsNeedCheckByCustomize[key]; ok {
+		validator, err := NewJsonSchemaValidator("customize." + string(key))

Review comment:
       Why not put this under "main"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org