You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Brian Hulette (Jira)" <ji...@apache.org> on 2019/09/04 01:08:00 UTC

[jira] [Commented] (BEAM-8146) SchemaCoder/RowCoder have no equals() function

    [ https://issues.apache.org/jira/browse/BEAM-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921799#comment-16921799 ] 

Brian Hulette commented on BEAM-8146:
-------------------------------------

[~reuvenlax] do you have any thoughts on the right way to implement equals() for SchemaCoder? I think for RowCoder we can just compare the schemas (or just the IDs), but I'm not sure how to handle the fromRow/toRow functions in Java. Maybe we should store a type descriptor and compare that as a proxy for the conversion functions?

> SchemaCoder/RowCoder have no equals() function
> ----------------------------------------------
>
>                 Key: BEAM-8146
>                 URL: https://issues.apache.org/jira/browse/BEAM-8146
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 2.15.0
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>            Priority: Major
>
> SchemaCoder has no equals function, so it can't be compared in tests, like CloudComponentsTests$DefaultCoders, which is being re-enabled in https://github.com/apache/beam/pull/9446



--
This message was sent by Atlassian Jira
(v8.3.2#803003)