You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/09 17:19:41 UTC

[GitHub] [incubator-nuttx-apps] patacongo opened a new pull request #244: examples/thttpd/content/tasks/tasks.c: Update OS internal name

patacongo opened a new pull request #244:
URL: https://github.com/apache/incubator-nuttx-apps/pull/244


   This logic uses the OS internal nxsched_foreach() function.  This is a violation of the POSIX OS interface.  But for now, we just update the name.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #244: examples/thttpd/content/tasks/tasks.c: Update OS internal name

Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #244:
URL: https://github.com/apache/incubator-nuttx-apps/pull/244#issuecomment-626211148


   In order to complete the renaming of sched functions, two things should be done:
   
   1. All of the functions in sched/sched/sched.h need to modified to follow the same naming conventions used in include/nuttx/sched.h:
   
       `nxsched_<verb>_<object>`
   
   2. Of much less importance, all of the numbers of static functions within sched/sched/*.c functions must be changed to follow that same convention.  This is less important because it is not exposed outside of the file.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #244: examples/thttpd/content/tasks/tasks.c: Update OS internal name

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #244:
URL: https://github.com/apache/incubator-nuttx-apps/pull/244#issuecomment-626211148


   In order to complete the renaming of sched functions, two things should be done:
   
   1. All of the functions in sched/sched/sched.h need to modified to follow the same naming conventions used in include/nuttx/sched.h:
   
       nxsched_<verb>_<object>
   
   2. Of much less importance, all of the numbers of static functions within sched/sched/*.c functions must be changed to follow that same convention.  This is less important because it is not exposed outside of the file.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #244: examples/thttpd/content/tasks/tasks.c: Update OS internal name

Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #244:
URL: https://github.com/apache/incubator-nuttx-apps/pull/244#issuecomment-626211148


   In order to complete the renaming of sched functions, two things should be done:
   
   1. All of the functions in sched/sched/sched.h need to modified to follow the same naming conventions used in include/nuttx/sched.h:
   
       `nxsched_<verb>_<object>`
   
   2. Of much less importance, all of the numbers of static functions within sched/sched/*.c functions must be changed to follow that same convention.  This is less important because it is not exposed outside of the file.
   
   This PR and the first step above are a lot of work.  That is not because there is much effort to the renaming.  I do that with a script and just verify the result.  But many files get modified and the effort is in make all of those modified files conform to the coding style.  I suspect that this PR fixes most of the style issues so hopefully, the first step above will not be such an effort.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org