You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/18 18:20:30 UTC
Review Request 70232: Fixed an agent crash bug when SLRP recovers
dropped operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70232/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
Bugs: MESOS-9661
https://issues.apache.org/jira/browse/MESOS-9661
Repository: mesos
Description
-------
Fixed an agent crash bug when SLRP recovers dropped operations.
Diffs
-----
src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
Diff: https://reviews.apache.org/r/70232/diff/1/
Testing
-------
`make check`
Thanks,
Chun-Hung Hsiao
Re: Review Request 70232: Fixed an agent crash bug when SLRP recovers
dropped operations.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70232/#review213783
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70232]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 18, 2019, 11:20 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70232/
> -----------------------------------------------------------
>
> (Updated March 18, 2019, 11:20 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9661
> https://issues.apache.org/jira/browse/MESOS-9661
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed an agent crash bug when SLRP recovers dropped operations.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
>
>
> Diff: https://reviews.apache.org/r/70232/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70232: Fixed an agent crash bug when SLRP recovers
dropped operations.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70232/#review213782
-----------------------------------------------------------
PASS: Mesos patch 70232 was successfully built and tested.
Reviews applied: `['70232']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2975/mesos-review-70232
- Mesos Reviewbot Windows
On March 18, 2019, 11:20 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70232/
> -----------------------------------------------------------
>
> (Updated March 18, 2019, 11:20 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9661
> https://issues.apache.org/jira/browse/MESOS-9661
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed an agent crash bug when SLRP recovers dropped operations.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
>
>
> Diff: https://reviews.apache.org/r/70232/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70232: Fixed an agent crash bug when SLRP recovers
dropped operations.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70232/#review213779
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On March 18, 2019, 7:20 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70232/
> -----------------------------------------------------------
>
> (Updated March 18, 2019, 7:20 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9661
> https://issues.apache.org/jira/browse/MESOS-9661
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed an agent crash bug when SLRP recovers dropped operations.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp fea623c292158deb1b4b4b9ab1ac208031471519
>
>
> Diff: https://reviews.apache.org/r/70232/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>