You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/01 21:45:23 UTC
[GitHub] [iceberg] rdblue commented on a change in pull request #1790: Core: Implement NaN counts in ORC
rdblue commented on a change in pull request #1790:
URL: https://github.com/apache/iceberg/pull/1790#discussion_r533741499
##########
File path: data/src/main/java/org/apache/iceberg/data/orc/GenericOrcWriter.java
##########
@@ -109,6 +112,10 @@ private WriteBuilder() {
iPrimitive, primitive));
}
}
+
+ private int getFieldId(TypeDescription typeDescription) {
Review comment:
I agree with @jackye1995. I probably wouldn't separate this out into its own method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org