You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/13 16:49:37 UTC
[GitHub] twalthr commented on a change in pull request #7087: [FLINK-10843]
[connectors] Make Kafka table factory versioning more flexible
twalthr commented on a change in pull request #7087: [FLINK-10843] [connectors] Make Kafka table factory versioning more flexible
URL: https://github.com/apache/flink/pull/7087#discussion_r233129481
##########
File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceSinkFactoryBase.java
##########
@@ -104,6 +106,7 @@
List<String> properties = new ArrayList<>();
// kafka
+ properties.add(CONNECTOR_VERSION);
Review comment:
This line is relevant. If it is not defined in the context, it must be added to the supported properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services