You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Zheaoli (via GitHub)" <gi...@apache.org> on 2023/10/18 14:39:22 UTC
[I] feat: Add edge test for all layers in opendal [incubator-opendal]
Zheaoli opened a new issue, #3346:
URL: https://github.com/apache/incubator-opendal/issues/3346
For now, we have 21 different layers in the OpenDAL project. But we don't have any choice but to make sure it works right or at least does not have any side effects to regular operation.
Like #3335 , I added a label in Prometheus metric but forgot to add it in a corner; the process would be panic if add the Prometheus layer. I fixed it because I ran the test before I made a PR. But if I don't do it and the reviewer does not figure it out, the layer would be broke(I think there is not any maintainer who is familiar with the all layer)
So I think we can add a edge test for all of the layer, we use the `memory` service and man the CRUD operation to just make sure any of the layer change would broken the normal operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: Add edge test for all layers in opendal [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3346:
URL: https://github.com/apache/incubator-opendal/issues/3346#issuecomment-1862055184
Adding edge tests for individual layers is beneficial, but doing so for `all layers` at once isn't a practical task. Let's create issues for each layer separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: Add edge test for all layers in opendal [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #3346:
URL: https://github.com/apache/incubator-opendal/issues/3346#issuecomment-1776746042
Edge testing is beneficial, but it may not be sensible for all layers. Perhaps we could examine each layer's test individually and determine if we can abstract something afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat: Add edge test for all layers in opendal [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #3346: feat: Add edge test for all layers in opendal
URL: https://github.com/apache/incubator-opendal/issues/3346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org