You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "sureshanaparti (via GitHub)" <gi...@apache.org> on 2026/08/17 10:54:30 UTC

[PR] Add externalloadbalanceripaddress field to KubernetesCluster struct [cloudstack-go]

sureshanaparti opened a new pull request, #163:
URL: https://github.com/apache/cloudstack-go/pull/163

   Exposes the external load balancer IP address parameter for Kubernetes clusters, enabling HA cluster deployments on Shared networks via the API client.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add externalloadbalanceripaddress field to KubernetesCluster struct [cloudstack-go]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #163:
URL: https://github.com/apache/cloudstack-go/pull/163#discussion_r3795791093


##########
cloudstack/KubernetesService.go:
##########
@@ -1830,56 +1830,57 @@ type ListKubernetesClustersResponse struct {
 }
 
 type KubernetesCluster struct {
-	Account               string            `json:"account"`
-	Associatednetworkname string            `json:"associatednetworkname"`
-	Autoscalingenabled    bool              `json:"autoscalingenabled"`
-	Clustertype           string            `json:"clustertype"`
-	Cniconfigname         string            `json:"cniconfigname"`
-	Cniconfigurationid    string            `json:"cniconfigurationid"`
-	Consoleendpoint       string            `json:"consoleendpoint"`
-	Controlnodes          int64             `json:"controlnodes"`
-	Controlofferingid     string            `json:"controlofferingid"`
-	Controlofferingname   string            `json:"controlofferingname"`
-	Cpunumber             string            `json:"cpunumber"`
-	Created               string            `json:"created"`
-	Csienabled            bool              `json:"csienabled"`
-	Description           string            `json:"description"`
-	Domain                string            `json:"domain"`
-	Domainid              string            `json:"domainid"`
-	Domainpath            string            `json:"domainpath"`
-	Endpoint              string            `json:"endpoint"`
-	Etcdips               map[string]string `json:"etcdips"`
-	Etcdnodes             int64             `json:"etcdnodes"`
-	Etcdofferingid        string            `json:"etcdofferingid"`
-	Etcdofferingname      string            `json:"etcdofferingname"`
-	Hasannotations        bool              `json:"hasannotations"`
-	Id                    string            `json:"id"`
-	Ipaddress             string            `json:"ipaddress"`
-	Ipaddressid           string            `json:"ipaddressid"`
-	JobID                 string            `json:"jobid"`
-	Jobstatus             int               `json:"jobstatus"`
-	Keypair               string            `json:"keypair"`
-	Kubernetesversionid   string            `json:"kubernetesversionid"`
-	Kubernetesversionname string            `json:"kubernetesversionname"`
-	Masternodes           int64             `json:"masternodes"`
-	Maxsize               int64             `json:"maxsize"`
-	Memory                string            `json:"memory"`
-	Minsize               int64             `json:"minsize"`
-	Name                  string            `json:"name"`
-	Networkid             string            `json:"networkid"`
-	Project               string            `json:"project"`
-	Projectid             string            `json:"projectid"`
-	Serviceofferingid     string            `json:"serviceofferingid"`
-	Serviceofferingname   string            `json:"serviceofferingname"`
-	Size                  int64             `json:"size"`
-	State                 string            `json:"state"`
-	Templateid            string            `json:"templateid"`
-	Templatename          string            `json:"templatename"`
-	Virtualmachines       []*VirtualMachine `json:"virtualmachines"`
-	Workerofferingid      string            `json:"workerofferingid"`
-	Workerofferingname    string            `json:"workerofferingname"`
-	Zoneid                string            `json:"zoneid"`
-	Zonename              string            `json:"zonename"`
+	Account                       string            `json:"account"`
+	Associatednetworkname         string            `json:"associatednetworkname"`
+	Autoscalingenabled            bool              `json:"autoscalingenabled"`
+	Clustertype                   string            `json:"clustertype"`
+	Cniconfigname                 string            `json:"cniconfigname"`
+	Cniconfigurationid            string            `json:"cniconfigurationid"`
+	Consoleendpoint               string            `json:"consoleendpoint"`
+	Controlnodes                  int64             `json:"controlnodes"`
+	Controlofferingid             string            `json:"controlofferingid"`
+	Controlofferingname           string            `json:"controlofferingname"`
+	Cpunumber                     string            `json:"cpunumber"`
+	Created                       string            `json:"created"`
+	Csienabled                    bool              `json:"csienabled"`
+	Description                   string            `json:"description"`
+	Domain                        string            `json:"domain"`
+	Domainid                      string            `json:"domainid"`
+	Domainpath                    string            `json:"domainpath"`
+	Endpoint                      string            `json:"endpoint"`
+	Etcdips                       map[string]string `json:"etcdips"`
+	Externalloadbalanceripaddress string            `json:"externalloadbalanceripaddress"`
+	Etcdnodes                     int64             `json:"etcdnodes"`

Review Comment:
   `Externalloadbalanceripaddress` was added to `KubernetesCluster`, but several other response structs in this same file duplicate the cluster fields (e.g. `CreateKubernetesClusterResponse`, `ScaleKubernetesClusterResponse`, `StartKubernetesClusterResponse`, `UpgradeKubernetesClusterResponse`, `AddNodesToKubernetesClusterResponse`, `RemoveNodesFromKubernetesClusterResponse`) and still won’t unmarshal this JSON field if the API returns it. To avoid inconsistent client behavior, please propagate this field to the other cluster-like response structs (or refactor them to reuse `KubernetesCluster`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org