[GitHub] [helix] pkuwm commented on pull request #1499: Trim strings in znrecord fields for REST json content

[GitBox <gi...@apache.org>]

pkuwm commented on pull request #1499:
URL: https://github.com/apache/helix/pull/1499#issuecomment-721335769


   > There are many good discussions. But unless we make some actions like this first or we can fix the UI issue quickly. There can be further production issues, which would take the team a lot of effort trouble shoot.
   > 
   > @pkuwm, can you have a look to see if UI fix can be done quickly. I will give an approve for now.
   
   @kaisun2000 @jiajunwang Thanks for the review! I still doubt the UI auto adds a leading space. We'll discuss more to determine a fair solution to improve it, eg: validate the the input and give warning/bad request response, or trim the spaces like this PR, etc..


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org