[jira] [Commented] (CAY-1626) Add JodaTime DateTime support

["Andrus Adamchik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAY-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818738#comment-13818738 ] 

Andrus Adamchik commented on CAY-1626:
--------------------------------------

Looks pretty good. I like the idea to a use a Module to ensure it is entirely optional. A few notes:

1. Joda dependency scope should probably be "provided" at framework/cayenne-core-unpublished/pom.xml. Doesn't matter much probablyas it is repackaged into cayenne-server eventually, but just to underscore that this is an extension.

2. Let's use SERVER_DEFAULT_TYPES_LIST instead of SERVER_USER_TYPES_LIST in the JodaModule - after all these are framework classes.

3. Maybe we can improve on 'isJodaAvailable' check in CommonsJdbcEventLogger ? Wonder if we can rewrite the whole 'sqlLiteralForObject' method and instead of guessing the print format of each object type, we take it from say ExtendedType. Extended types can be injected, like we are injecting them to DbAdapters.

> Add JodaTime DateTime support
> -----------------------------
>
>                 Key: CAY-1626
>                 URL: https://issues.apache.org/jira/browse/CAY-1626
>             Project: Cayenne
>          Issue Type: Improvement
>          Components: Database integration
>    Affects Versions: 3.1M2
>            Reporter: Marc O'Morain
>         Attachments: 0001-Add-support-for-joda-time-attributes.patch, DateTimeType.java, joda-patch.txt
>
>
> Here is some code that we wrote at Swrve to load/save jodatime DateTime objects with Cayenne



--
This message was sent by Atlassian JIRA
(v6.1#6144)