You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/10/04 22:19:05 UTC

Re: Review Request 12228: wip: static resource compression

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/
-----------------------------------------------------------

(Updated Oct. 4, 2013, 8:19 p.m.)


Review request for cloudstack, Brian Federle and Prasanna Santhanam.


Summary (updated)
-----------------

wip: static resource compression


Repository: cloudstack-git


Description
-------

CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.

This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.


Diffs
-----

  client/WEB-INF/web.xml e5c05d3 
  client/pom.xml 119c96e 
  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12228/diff/


Testing
-------


Thanks,

Laszlo Hornyak

Re: Review Request 12228: static resource compression

Posted by Laszlo Hornyak <la...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/#review41058
-----------------------------------------------------------


ping?

- Laszlo Hornyak


On April 18, 2014, 11:08 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12228/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 11:08 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle, Darren Shepherd, Jessica Wang, and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.
> 
> This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.
> 
> 
> Diffs
> -----
> 
>   client/WEB-INF/web.xml 1af38e1 
>   client/pom.xml aee2672 
>   server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
>   server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12228/diff/
> 
> 
> Testing
> -------
> 
> yes, tested with firefox and chrome
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>

Re: Review Request 12228: static resource compression

Posted by Laszlo Hornyak <la...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/
-----------------------------------------------------------

(Updated April 18, 2014, 11:08 p.m.)


Review request for cloudstack, Brian Federle, Darren Shepherd, Jessica Wang, and Prasanna Santhanam.


Changes
-------

removed a pair of critical trailing white spaces


Repository: cloudstack-git


Description
-------

CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.

This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.


Diffs (updated)
-----

  client/WEB-INF/web.xml 1af38e1 
  client/pom.xml aee2672 
  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12228/diff/


Testing
-------

yes, tested with firefox and chrome


Thanks,

Laszlo Hornyak

Re: Review Request 12228: static resource compression

Posted by Brian Federle <br...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/#review39322
-----------------------------------------------------------


Lazlo, I just tested your changes and everything looks good to me.

- Brian Federle


On March 30, 2014, 8:08 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12228/
> -----------------------------------------------------------
> 
> (Updated March 30, 2014, 8:08 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle, Darren Shepherd, Jessica Wang, and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.
> 
> This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.
> 
> 
> Diffs
> -----
> 
>   client/WEB-INF/web.xml 1af38e1 
>   client/pom.xml d8dbde7 
>   server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
>   server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12228/diff/
> 
> 
> Testing
> -------
> 
> yes, tested with firefox and chrome
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>

Re: Review Request 12228: static resource compression

Posted by Laszlo Hornyak <la...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/
-----------------------------------------------------------

(Updated March 30, 2014, 8:08 p.m.)


Review request for cloudstack, Brian Federle, Darren Shepherd, Jessica Wang, and Prasanna Santhanam.


Repository: cloudstack-git


Description
-------

CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.

This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.


Diffs
-----

  client/WEB-INF/web.xml 1af38e1 
  client/pom.xml d8dbde7 
  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12228/diff/


Testing
-------

yes, tested with firefox and chrome


Thanks,

Laszlo Hornyak

Re: Review Request 12228: static resource compression

Posted by Laszlo Hornyak <la...@gmail.com>.


> On March 21, 2014, 8:07 p.m., Laszlo Hornyak wrote:
> > https://docs.google.com/spreadsheet/ccc?key=0ApMkIX1Ygx8zdHhqV2RETy05SDU1WER3Z2JEN3ktZHc&usp=sharing
> > 
> > Comparison of 3 configurations, the dynamic compression solution is the last one. This test was conducted in a VM with 2 vCPU and 4 GB RAM on a 
> > AMD E2-1800.
> >

Anyone managed to verify the results? Comments or thoughts?


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/#review38181
-----------------------------------------------------------


On March 20, 2014, 7:53 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12228/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 7:53 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.
> 
> This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.
> 
> 
> Diffs
> -----
> 
>   client/WEB-INF/web.xml 1af38e1 
>   client/pom.xml d8dbde7 
>   server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
>   server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12228/diff/
> 
> 
> Testing
> -------
> 
> yes, tested with firefox and chrome
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>

Re: Review Request 12228: static resource compression

Posted by Laszlo Hornyak <la...@gmail.com>.

Hi John,

I used simple apache benchmark with a random selected css.
ab -n 2000 -H "Accept-Encoding: gzip, deflate"
http://172.17.10.10/client/css/cloudstack3.css

This looks big enough, it is about 200 K uncompressed.

I used the configuration you published in your blog and I disabled the
static resource compression by commenting the servlet out from the web.xml,
I verified the configurations by examining the headers and message body.
Since the tested VM is a local VM, the network latency is really close to
zero.

Please share your results! I was surprised first about the low performance
of dynamic compression, I expected it to be somewhat slower and I believe
the resource size or maybe even the content itself can alter the results.
But theoretically it can never be as fast as static compression since that
is just plain IO.

Some other comparisons done by others
http://www.webperformance.com/library/reports/moddeflate/
http://www.webperformance.com/library/reports/iis7_compression/ - ISS too

As I wrote, I believe the best solution would be combining both static and
dynamic.


On Fri, Mar 21, 2014 at 10:03 PM, John Kinsella <jl...@stratosec.co> wrote:

>  Canya tell us a little more about the test you're doing? What URL are you
> fetching, how many times etc. Just curious to tinker myself this weekend if
> I have some time. :)
>
>  On Mar 21, 2014, at 1:07 PM, Laszlo Hornyak <la...@gmail.com>
> wrote:
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12228/#review38181
> -----------------------------------------------------------
>
>
>
> https://docs.google.com/spreadsheet/ccc?key=0ApMkIX1Ygx8zdHhqV2RETy05SDU1WER3Z2JEN3ktZHc&usp=sharing
>
> Comparison of 3 configurations, the dynamic compression solution is the
> last one. This test was conducted in a VM with 2 vCPU and 4 GB RAM on a
> AMD E2-1800.
>
>
> - Laszlo Hornyak
>
>
> On March 20, 2014, 7:53 p.m., Laszlo Hornyak wrote:
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12228/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 7:53 p.m.)
>
>
> Review request for cloudstack, Brian Federle, Darren Shepherd, and
> Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CloudStack at first use downloads some 3.5 MB of css and javascript to the
> client. With a weak internet connection, this might take a long time. With
> gzip compression content can be compressed to 850 KB.
>
> This version of the patch uses a custom plugin to compress static
> resources, so that no dynamic compression is needed at runtime. When the
> static resource servlet notices that there is gzipped version of the
> resource and the client accepts gzipped content, then it is going to send
> the gziped version, while still respects http caching.
>
>
> Diffs
> -----
>
>  client/WEB-INF/web.xml 1af38e1
>  client/pom.xml d8dbde7
>  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION
>  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12228/diff/
>
>
> Testing
> -------
>
> yes, tested with firefox and chrome
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
>
>
>  Stratosec <http://stratosec.co/> - Compliance as a Service
> o: 415.315.9385
> @johnlkinsella <http://twitter.com/johnlkinsella>
>
>


-- 

EOF

Re: Review Request 12228: static resource compression

Posted by John Kinsella <jl...@stratosec.co>.

Canya tell us a little more about the test you’re doing? What URL are you fetching, how many times etc. Just curious to tinker myself this weekend if I have some time. :)

On Mar 21, 2014, at 1:07 PM, Laszlo Hornyak <la...@gmail.com>> wrote:

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/#review38181
-----------------------------------------------------------

https://docs.google.com/spreadsheet/ccc?key=0ApMkIX1Ygx8zdHhqV2RETy05SDU1WER3Z2JEN3ktZHc&usp=sharing

Comparison of 3 configurations, the dynamic compression solution is the last one. This test was conducted in a VM with 2 vCPU and 4 GB RAM on a
AMD E2-1800.

- Laszlo Hornyak

On March 20, 2014, 7:53 p.m., Laszlo Hornyak wrote:

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/
-----------------------------------------------------------

(Updated March 20, 2014, 7:53 p.m.)

Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna Santhanam.

Repository: cloudstack-git

Description
-------

CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.

This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.

Diffs
-----

client/WEB-INF/web.xml 1af38e1
client/pom.xml d8dbde7
server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION
server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION

Diff: https://reviews.apache.org/r/12228/diff/

Testing
-------

yes, tested with firefox and chrome

Thanks,

Laszlo Hornyak

Stratosec<http://stratosec.co/> - Compliance as a Service
o: 415.315.9385
@johnlkinsella<http://twitter.com/johnlkinsella>

Re: Review Request 12228: static resource compression

Posted by Laszlo Hornyak <la...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/#review38181
-----------------------------------------------------------


https://docs.google.com/spreadsheet/ccc?key=0ApMkIX1Ygx8zdHhqV2RETy05SDU1WER3Z2JEN3ktZHc&usp=sharing

Comparison of 3 configurations, the dynamic compression solution is the last one. This test was conducted in a VM with 2 vCPU and 4 GB RAM on a 
AMD E2-1800.


- Laszlo Hornyak


On March 20, 2014, 7:53 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12228/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 7:53 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.
> 
> This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.
> 
> 
> Diffs
> -----
> 
>   client/WEB-INF/web.xml 1af38e1 
>   client/pom.xml d8dbde7 
>   server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
>   server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12228/diff/
> 
> 
> Testing
> -------
> 
> yes, tested with firefox and chrome
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>

Re: Review Request 12228: static resource compression

Posted by Laszlo Hornyak <la...@gmail.com>.

url: https://wiki.eclipse.org/Jetty/Feature/GZIP_Compression#Static_Content


On Thu, Mar 20, 2014 at 11:19 PM, John Kinsella <jl...@stratosec.co> wrote:

>  Laszlo, can you reference any other open source projects that have
> similar solutions to this issue? Anything I've read states dynamic
> compression in tomcat/httpd/nginx does not add significant CPU overhead.
>
>  On Mar 20, 2014, at 12:53 PM, Laszlo Hornyak <la...@gmail.com>
> wrote:
>
>
> -----------------------------------------------------------
>
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12228/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 7:53 p.m.)
>
>
>
> Review request for cloudstack, Brian Federle, Darren Shepherd, and
> Prasanna Santhanam.
>
>
> Changes
> -------
>
> spaces
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> CloudStack at first use downloads some 3.5 MB of css and javascript to the
> client. With a weak internet connection, this might take a long time. With
> gzip compression content can be compressed to 850 KB.
>
> This version of the patch uses a custom plugin to compress static
> resources, so that no dynamic compression is needed at runtime. When the
> static resource servlet notices that there is gzipped version of the
> resource and the client accepts gzipped content, then it is going to send
> the gziped version, while still respects http caching.
>
>
> Diffs (updated)
> -----
>
>  client/WEB-INF/web.xml 1af38e1
>  client/pom.xml d8dbde7
>  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION
>  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12228/diff/
>
>
> Testing
> -------
>
>
> yes, tested with firefox and chrome
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
>  Stratosec <http://stratosec.co/> - Compliance as a Service
> o: 415.315.9385
> @johnlkinsella <http://twitter.com/johnlkinsella>
>
>


-- 

EOF

Re: Review Request 12228: static resource compression

Posted by Laszlo Hornyak <la...@gmail.com>.

Hi John,

Jetty gives this functionality by default without a filter/servlet, simply
it is not available in tomcat. I used this functionality a lot in jetty and
that plus the massive size of the UI gave me the idea.
My approach to the problem was motivated by that I don't like to see
anything wasted, but let's make a measurement and see what the impact is.
This is what could be interesting in comparison with dynamic compression:
- request/sec and average delay for static resoures in different sizes
- time taken by full page reload




On Thu, Mar 20, 2014 at 11:19 PM, John Kinsella <jl...@stratosec.co> wrote:

>  Laszlo, can you reference any other open source projects that have
> similar solutions to this issue? Anything I've read states dynamic
> compression in tomcat/httpd/nginx does not add significant CPU overhead.
>
>  On Mar 20, 2014, at 12:53 PM, Laszlo Hornyak <la...@gmail.com>
> wrote:
>
>
> -----------------------------------------------------------
>
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12228/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 7:53 p.m.)
>
>
>
> Review request for cloudstack, Brian Federle, Darren Shepherd, and
> Prasanna Santhanam.
>
>
> Changes
> -------
>
> spaces
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> CloudStack at first use downloads some 3.5 MB of css and javascript to the
> client. With a weak internet connection, this might take a long time. With
> gzip compression content can be compressed to 850 KB.
>
> This version of the patch uses a custom plugin to compress static
> resources, so that no dynamic compression is needed at runtime. When the
> static resource servlet notices that there is gzipped version of the
> resource and the client accepts gzipped content, then it is going to send
> the gziped version, while still respects http caching.
>
>
> Diffs (updated)
> -----
>
>  client/WEB-INF/web.xml 1af38e1
>  client/pom.xml d8dbde7
>  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION
>  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/12228/diff/
>
>
> Testing
> -------
>
>
> yes, tested with firefox and chrome
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
>  Stratosec <http://stratosec.co/> - Compliance as a Service
> o: 415.315.9385
> @johnlkinsella <http://twitter.com/johnlkinsella>
>
>


-- 

EOF

Re: Review Request 12228: static resource compression

Posted by John Kinsella <jl...@stratosec.co>.

Laszlo, can you reference any other open source projects that have similar solutions to this issue? Anything I’ve read states dynamic compression in tomcat/httpd/nginx does not add significant CPU overhead.

On Mar 20, 2014, at 12:53 PM, Laszlo Hornyak <la...@gmail.com>> wrote:


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/
-----------------------------------------------------------

(Updated March 20, 2014, 7:53 p.m.)


Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna Santhanam.


Changes
-------

spaces


Repository: cloudstack-git


Description
-------

CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.

This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.


Diffs (updated)
-----

 client/WEB-INF/web.xml 1af38e1
 client/pom.xml d8dbde7
 server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION
 server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION

Diff: https://reviews.apache.org/r/12228/diff/


Testing
-------

yes, tested with firefox and chrome


Thanks,

Laszlo Hornyak


Stratosec<http://stratosec.co/> - Compliance as a Service
o: 415.315.9385
@johnlkinsella<http://twitter.com/johnlkinsella>

Re: Review Request 12228: static resource compression

Posted by Laszlo Hornyak <la...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/
-----------------------------------------------------------

(Updated March 20, 2014, 7:53 p.m.)


Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna Santhanam.


Changes
-------

spaces


Repository: cloudstack-git


Description
-------

CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.

This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.


Diffs (updated)
-----

  client/WEB-INF/web.xml 1af38e1 
  client/pom.xml d8dbde7 
  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12228/diff/


Testing
-------

yes, tested with firefox and chrome


Thanks,

Laszlo Hornyak

Re: Review Request 12228: static resource compression

Posted by Laszlo Hornyak <la...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/
-----------------------------------------------------------

(Updated March 19, 2014, 8:13 p.m.)


Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna Santhanam.


Changes
-------

-updated to use plugin from central repo
-fixed spaces/tabs
-license header added


Summary (updated)
-----------------

static resource compression


Repository: cloudstack-git


Description
-------

CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.

This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.


Diffs (updated)
-----

  client/WEB-INF/web.xml 1af38e1 
  client/pom.xml 615d244 
  server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
  server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12228/diff/


Testing (updated)
-------

yes, tested with firefox and chrome


Thanks,

Laszlo Hornyak

Re: Review Request 12228: static resource compression

Posted by daan Hoogland <da...@gmail.com>.


> On Feb. 2, 2014, 6:03 p.m., daan Hoogland wrote:
> > client/WEB-INF/web.xml, line 63
> > <https://reviews.apache.org/r/12228/diff/2/?file=354637#file354637line63>
> >
> >     can you use tabs instead of spaces (and while you are at it remove trailing spaces from this file)?
> 
> Laszlo Hornyak wrote:
>     trailing white spaces: ok
>     spaces to tabs: all this file is tabed with spaces, so this would be the first thing with tabs.

sorry i mean 'spaces instead of tabs'not vice versa.


- daan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/#review33400
-----------------------------------------------------------


On March 19, 2014, 8:13 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12228/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 8:13 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.
> 
> This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.
> 
> 
> Diffs
> -----
> 
>   client/WEB-INF/web.xml 1af38e1 
>   client/pom.xml 615d244 
>   server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
>   server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12228/diff/
> 
> 
> Testing
> -------
> 
> yes, tested with firefox and chrome
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>

Re: Review Request 12228: static resource compression

Posted by Laszlo Hornyak <la...@gmail.com>.


> On Feb. 2, 2014, 6:03 p.m., daan Hoogland wrote:
> > client/WEB-INF/web.xml, line 63
> > <https://reviews.apache.org/r/12228/diff/2/?file=354637#file354637line63>
> >
> >     can you use tabs instead of spaces (and while you are at it remove trailing spaces from this file)?

trailing white spaces: ok
spaces to tabs: all this file is tabed with spaces, so this would be the first thing with tabs.


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12228/#review33400
-----------------------------------------------------------


On March 19, 2014, 8:13 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12228/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 8:13 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle, Darren Shepherd, and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CloudStack at first use downloads some 3.5 MB of css and javascript to the client. With a weak internet connection, this might take a long time. With gzip compression content can be compressed to 850 KB.
> 
> This version of the patch uses a custom plugin to compress static resources, so that no dynamic compression is needed at runtime. When the static resource servlet notices that there is gzipped version of the resource and the client accepts gzipped content, then it is going to send the gziped version, while still respects http caching.
> 
> 
> Diffs
> -----
> 
>   client/WEB-INF/web.xml 1af38e1 
>   client/pom.xml 615d244 
>   server/src/com/cloud/servlet/StaticResourceServlet.java PRE-CREATION 
>   server/test/com/cloud/servlet/StaticResourceServletTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12228/diff/
> 
> 
> Testing
> -------
> 
> yes, tested with firefox and chrome
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>