[GitHub] [airflow] jedcunningham commented on a diff in pull request #24083: Reduce grid view API calls

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #24083:
URL: https://github.com/apache/airflow/pull/24083#discussion_r887016507


##########
airflow/www/static/js/grid/index.jsx:
##########
@@ -48,6 +48,7 @@ const queryClient = new QueryClient({
       refetchOnWindowFocus: false,
       retry: 1,
       retryDelay: 500,
+      staleTime: 5 * 60 * 1000, // 5 minutes

Review Comment:
   Just to double check, this doesn't apply on refresh, right?



##########
airflow/www/static/js/grid/utils/gridData.js:
##########
@@ -17,18 +17,5 @@
  * under the License.
  */
 
-import camelcaseKeys from 'camelcase-keys';
-
 export const areActiveRuns = (runs = []) => runs.filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0;
-
-export const formatData = (data, emptyData) => {
-  if (!data || !Object.keys(data).length) {
-    return emptyData;
-  }
-  let formattedData = data;
-  // Convert to json if needed
-  if (typeof data === 'string') formattedData = JSON.parse(data);
-  // change from pascal to camelcase
-  formattedData = camelcaseKeys(formattedData, { deep: true });
-  return formattedData;
-};
+export const somethingElse = '';

Review Comment:
   Was this intentional?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org