You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/06/23 22:06:00 UTC
[jira] [Commented] (LUCENE-9142) Add documentation to
Operations.determinize, SortedIntSet, and FrozenSet
[ https://issues.apache.org/jira/browse/LUCENE-9142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17368482#comment-17368482 ]
ASF subversion and git services commented on LUCENE-9142:
---------------------------------------------------------
Commit c6b9dd95c9f4b9ab9bac5904988432bba2ad4bd3 in lucene-solr's branch refs/heads/branch_8x from Patrick Zhai
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=c6b9dd9 ]
Backport LUCENE-9142 and LUCENE-9983 (#2517)
* LUCENE-9142 Refactor IntSet operations for determinize (#1184)
Co-authored-by: Mike <ma...@users.noreply.github.com>
> Add documentation to Operations.determinize, SortedIntSet, and FrozenSet
> ------------------------------------------------------------------------
>
> Key: LUCENE-9142
> URL: https://issues.apache.org/jira/browse/LUCENE-9142
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/search
> Reporter: Mike Drob
> Assignee: Mike Drob
> Priority: Major
> Fix For: main (9.0)
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Was tracing through the fuzzy query code, and IntelliJ helpfully pointed out that we have mismatched types when trying to reuse states, and so we may be creating more states than we need to.
> Relevant snippets:
> {code:title=Operations.java}
> Map<SortedIntSet.FrozenIntSet,Integer> newstate = new HashMap<>();
> final SortedIntSet statesSet = new SortedIntSet(5);
> Integer q = newstate.get(statesSet);
> {code}
> {{q}} is always going to be null in this path because there are no SortedIntSet keys in the map.
> There are also very little javadoc on SortedIntSet, so I'm having trouble following the precise relationship between all the pieces here.
> cc: [~mikemccand] [~romseygeek] - I would appreciate any pointers if you have them
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org