You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2024/01/31 11:07:46 UTC

[PR] ORC-1604: Remove non-utf8 bloom filter for writer [orc]

cxzl25 opened a new pull request, #1776:
URL: https://github.com/apache/orc/pull/1776

   ### What changes were proposed in this pull request?
   This PR aims to remove non-utf8 bloom filter for writer.
   1. Remove the configuration item `orc.bloom.filter.write.version`
   2. `BloomFilterUtf8` is used by default, consistent with C++ writer
   
   ### Why are the changes needed?
   1. `orc.bloom.filter.write.version=original` will write two copies of data instead of one, which increases the size of ORC and will also cause Spark2.x to fail to read `BloomFilterUtf8`
   [comment-17800800](https://issues.apache.org/jira/browse/ORC-297?focusedCommentId=17800800&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17800800)
   2. C++ writer does not implement original
   3. Plan to remove non-utf8 bloom filter in `orc-format` `ORCv2.md`
   
   
   ### How was this patch tested?
   GA
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1604: Deprecate non-utf8 bloom filter for Java writer [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1776:
URL: https://github.com/apache/orc/pull/1776#issuecomment-1925237339

   Thank you for updates. Merged to main/2.0 for Apache ORC 2.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ORC-1604: Deprecate non-utf8 bloom filter for Java writer [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #1776: ORC-1604: Deprecate non-utf8 bloom filter for Java writer
URL: https://github.com/apache/orc/pull/1776


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org