You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/23 11:31:09 UTC

[GitHub] [flink] KarmaGYZ opened a new pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

KarmaGYZ opened a new pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666
 
 
   
   ## What is the purpose of the change
   
   Introduce multiple submission e2e test for Flink's Mesos integration.
   
   
   ## Brief change log
   
    - 43b1425..
   2885bab: Hotfixes, refactors and code clean-ups.
    - ab3c8ac: Introduce multiple submission e2e test
    - cc596f9: Enable it in Travis and nightly script
   
   
   ## Verifying this change
   
    - Run multiple submission e2e test 
   `./run-single-test.sh test-scripts/test_mesos_multi_submission.sh`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r364230155
 
 

 ##########
 File path: tools/travis/splits/split_container.sh
 ##########
 @@ -51,6 +51,7 @@ run_test "Run kubernetes test" "$END_TO_END_DIR/test-scripts/test_kubernetes_emb
 run_test "Run kubernetes session test" "$END_TO_END_DIR/test-scripts/test_kubernetes_session.sh"
 if [[ "${HADOOP_INTEGRATION}" = "with-hadoop" ]]; then
     run_test "Run Mesos WordCount test" "$END_TO_END_DIR/test-scripts/test_mesos_wordcount.sh"
 
 Review comment:
   I agree with your conclusion that ideally we try to separate test cases but in this case it might acceptable to consolidate them in order to save build time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r364789174
 
 

 ##########
 File path: tools/travis/splits/split_container.sh
 ##########
 @@ -51,6 +51,7 @@ run_test "Run kubernetes test" "$END_TO_END_DIR/test-scripts/test_kubernetes_emb
 run_test "Run kubernetes session test" "$END_TO_END_DIR/test-scripts/test_kubernetes_session.sh"
 if [[ "${HADOOP_INTEGRATION}" = "with-hadoop" ]]; then
     run_test "Run Mesos WordCount test" "$END_TO_END_DIR/test-scripts/test_mesos_wordcount.sh"
 
 Review comment:
   I am ok to consolidate them with the next test that we add.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142956703 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142956703) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060) 
   * 9113fc48d92a1802fef17e51d9df71b2a1a70465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143187251) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363319026
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -456,14 +456,21 @@ function wait_job_running {
   exit 1
 }
 
+function wait_job_terminal_state_mesos {
+  local job=$1
+  local expected_terminal_state=$2
+  wait_job_terminal_state $1 $2 "mesos-appmaster"
+}
+
 function wait_job_terminal_state {
   local job=$1
   local expected_terminal_state=$2
+  local log_file_name=${3:-standalonesession}
 
   echo "Waiting for job ($job) to reach terminal state $expected_terminal_state ..."
 
   while : ; do
-    local N=$(grep -o "Job $job reached globally terminal state .*" $FLINK_DIR/log/*standalonesession*.log | tail -1 || true)
+    local N=$(grep -o "Job $job reached globally terminal state .*" $FLINK_DIR/log/*$log_file_name*.log | tail -1 || true)
 
 Review comment:
   Agreed. We could move these functions to `common_mesos.sh`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142956703 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:MANUAL TriggerID:571021845
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:MANUAL TriggerID:571021845
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142956703) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060) 
   * 9113fc48d92a1802fef17e51d9df71b2a1a70465 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143187251) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363316318
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multiple_submissions.sh
 ##########
 @@ -0,0 +1,54 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
 
 Review comment:
   Can we reduce the duration to 5 seconds, or is there a benefit to let the job run longer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-571413688
 
 
   PR updated. Travis link https://travis-ci.org/KarmaGYZ/flink/builds/633584594

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363827085
 
 

 ##########
 File path: tools/travis/splits/split_container.sh
 ##########
 @@ -51,6 +51,7 @@ run_test "Run kubernetes test" "$END_TO_END_DIR/test-scripts/test_kubernetes_emb
 run_test "Run kubernetes session test" "$END_TO_END_DIR/test-scripts/test_kubernetes_session.sh"
 if [[ "${HADOOP_INTEGRATION}" = "with-hadoop" ]]; then
     run_test "Run Mesos WordCount test" "$END_TO_END_DIR/test-scripts/test_mesos_wordcount.sh"
 
 Review comment:
   I agree that a separate test makes it easier to locate the root cause. However, due to being expensive, E2E tests should not be used for exhaustively testing all cases. Currently, running all E2E tests take more than 24 CPU hours on Travis. `e2e - container - hadoop 2.8` takes ~43 minutes on Travis, which is not great but acceptable. Imo, if we decide to add more Mesos tests, we should start to consolidate soon.
   
   cc: @tillrohrmann 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r362769620
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multi_submission.sh
 ##########
 @@ -0,0 +1,58 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
+CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
 
 Review comment:
   I think there is no harm to start the Mesos agent with more CPU resources than the undlying hardware has to offer. The `cpus` resource value is virtual and should be only relevant for bookkeeping. Furthermore, it is not clear how Mesos determines the number of CPUs, and whether their automatically determined value will match ours. To keep things simple, we can just set the mesos CPU resources to `1`. Please let me know if I am missing something.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142956703 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142956703) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060) 
   * 9113fc48d92a1802fef17e51d9df71b2a1a70465 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143187251) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r362700324
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multi_submission.sh
 ##########
 @@ -0,0 +1,58 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
+CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
+FIRST_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/first_out"
+SECOND_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/second_out"
+TEST_PROGRAM_JAR=$END_TO_END_DIR/flink-cli-test/target/PeriodicStreamingJob.jar
+if [[ "$OSTYPE" == "linux-gnu" ]]; then
+    CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
+elif [[ "$OSTYPE" == "darwin"* ]]; then
+    CPUS=$(sysctl -n hw.ncpu)
+else
+    echo "Could not verify the OS type."
+    exit 1
+fi
+
+
+mkdir -p "${TEST_DATA_DIR}"
+
+# There should be only one TaskManager with one slot; Thus, there are not enough resources to allocate a complete new set of slots for the second job.
+# To ensure the old slots are being reused.
+set_config_key "mesos.resourcemanager.tasks.cpus" "${CPUS}"
+
+start_flink_cluster_with_mesos
+
+JOB1_ID=$(docker exec -it mesos-master bash -c "${FLINK_DIR}/bin/flink run -d -p 1 ${TEST_PROGRAM_JAR} --durationInSecond ${FIRST_DURATION} --outputPath ${FIRST_OUTPUT_LOCATION}" \
+        | grep "Job has been submitted with JobID" | sed 's/.* //g' | tr -d '\r')
+
+wait_num_of_occurence_in_logs_mesos "switched from DEPLOYING to RUNNING" 1
 
 Review comment:
   I think it's better to add this check to ensure the first job already occupy the slot and the second job need to wait for that slot to be free.
   If you think it's fragile, I'd like to harden this function. But so far, I do not figure out the fragile point here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363776202
 
 

 ##########
 File path: tools/travis/splits/split_container.sh
 ##########
 @@ -51,6 +51,7 @@ run_test "Run kubernetes test" "$END_TO_END_DIR/test-scripts/test_kubernetes_emb
 run_test "Run kubernetes session test" "$END_TO_END_DIR/test-scripts/test_kubernetes_session.sh"
 if [[ "${HADOOP_INTEGRATION}" = "with-hadoop" ]]; then
     run_test "Run Mesos WordCount test" "$END_TO_END_DIR/test-scripts/test_mesos_wordcount.sh"
 
 Review comment:
   Can you define what you mean by _"openbox"_?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363316956
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/docker-mesos-cluster/docker-compose.yml
 ##########
 @@ -55,6 +55,7 @@ services:
     volumes:
       - ${END_TO_END_DIR}:${END_TO_END_DIR}
     environment:
+      MESOS_RESOURCES: "cpus:1"
 
 Review comment:
   I think we could export a global variable `MESOS_CPU` in `common_mesos.sh`. In `test_mesos_multiple_submissions`, we just need to set the cpu of taskExecutor to this value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r362499006
 
 

 ##########
 File path: flink-end-to-end-tests/run-nightly-tests.sh
 ##########
 @@ -119,6 +119,7 @@ run_test "Run kubernetes session test" "$END_TO_END_DIR/test-scripts/test_kubern
 ################################################################################
 
 run_test "Run Mesos WordCount test" "$END_TO_END_DIR/test-scripts/test_mesos_wordcount.sh"
+run_test "Run Mesos multiple submission test" "$END_TO_END_DIR/test-scripts/test_mesos_multi_submission.sh"
 
 Review comment:
   Maybe 
   ```
   test_mesos_multiple_submissions.sh
                   ~~~           ~
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r362701507
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multi_submission.sh
 ##########
 @@ -0,0 +1,58 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
+CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
 
 Review comment:
   Good catch. It's a redundant line.
   Yes, I have also considered that way. However, I've a concern makes me not choosing that option. I think the auto-discovered value will free us from the the hardware limitation. For example, if we set it to 4, what if there is not enough cpu core in Travis or developer's environment? It's tricky to determine this value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363321661
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multiple_submissions.sh
 ##########
 @@ -0,0 +1,54 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
 
 Review comment:
   We can, that is exactly what I do in next version

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142956703 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:MANUAL TriggerID:571021845
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:MANUAL TriggerID:571021845
   Hash:5a5c93dcead65507f3208c36ae0e23ebf395674a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:5a5c93dcead65507f3208c36ae0e23ebf395674a
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142956703) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060) 
   * 9113fc48d92a1802fef17e51d9df71b2a1a70465 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143187251) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104) 
   * 5a5c93dcead65507f3208c36ae0e23ebf395674a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142956703 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142956703) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060) 
   * 9113fc48d92a1802fef17e51d9df71b2a1a70465 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143187251) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r362498452
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multi_submission.sh
 ##########
 @@ -0,0 +1,58 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
+CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
+FIRST_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/first_out"
+SECOND_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/second_out"
+TEST_PROGRAM_JAR=$END_TO_END_DIR/flink-cli-test/target/PeriodicStreamingJob.jar
+if [[ "$OSTYPE" == "linux-gnu" ]]; then
+    CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
+elif [[ "$OSTYPE" == "darwin"* ]]; then
+    CPUS=$(sysctl -n hw.ncpu)
+else
+    echo "Could not verify the OS type."
+    exit 1
+fi
+
+
+mkdir -p "${TEST_DATA_DIR}"
+
+# There should be only one TaskManager with one slot; Thus, there are not enough resources to allocate a complete new set of slots for the second job.
+# To ensure the old slots are being reused.
+set_config_key "mesos.resourcemanager.tasks.cpus" "${CPUS}"
+
+start_flink_cluster_with_mesos
+
+JOB1_ID=$(docker exec -it mesos-master bash -c "${FLINK_DIR}/bin/flink run -d -p 1 ${TEST_PROGRAM_JAR} --durationInSecond ${FIRST_DURATION} --outputPath ${FIRST_OUTPUT_LOCATION}" \
+        | grep "Job has been submitted with JobID" | sed 's/.* //g' | tr -d '\r')
+
+wait_num_of_occurence_in_logs_mesos "switched from DEPLOYING to RUNNING" 1
+
+JOB2_ID=$(docker exec -it mesos-master bash -c "${FLINK_DIR}/bin/flink run -d -p 1 ${TEST_PROGRAM_JAR} --durationInSecond ${SECOND_DURATION} --outputPath ${SECOND_OUTPUT_LOCATION}" \
 
 Review comment:
   We should avoid code duplication. At least in this file we can extract a function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-571021845
 
 
   @flinkbot run travis

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r362769845
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -456,14 +456,21 @@ function wait_job_running {
   exit 1
 }
 
+function wait_job_terminal_state_mesos {
+  local job=$1
+  local expected_terminal_state=$2
+  wait_job_terminal_state $1 $2 "mesos-appmaster"
+}
+
 function wait_job_terminal_state {
   local job=$1
   local expected_terminal_state=$2
+  local log_file_name=${3-standalonesession}
 
 Review comment:
   I'd also use ${3:-standalonesession} for consistency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-570981257
 
 
   Thanks for the review @GJL . All the comments addressed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-571612848
 
 
   Merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142956703 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:MANUAL TriggerID:571021845
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142956703) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060) 
   * 9113fc48d92a1802fef17e51d9df71b2a1a70465 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143187251) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142956703 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:MANUAL TriggerID:571021845
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:MANUAL TriggerID:571021845
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142956703) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060) 
   * 9113fc48d92a1802fef17e51d9df71b2a1a70465 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143187251) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363038375
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multi_submission.sh
 ##########
 @@ -0,0 +1,58 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
+CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
 
 Review comment:
   Thanks to let me know this. Agreed to set it to 1 in this test case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r364574063
 
 

 ##########
 File path: tools/travis/splits/split_container.sh
 ##########
 @@ -51,6 +51,7 @@ run_test "Run kubernetes test" "$END_TO_END_DIR/test-scripts/test_kubernetes_emb
 run_test "Run kubernetes session test" "$END_TO_END_DIR/test-scripts/test_kubernetes_session.sh"
 if [[ "${HADOOP_INTEGRATION}" = "with-hadoop" ]]; then
     run_test "Run Mesos WordCount test" "$END_TO_END_DIR/test-scripts/test_mesos_wordcount.sh"
 
 Review comment:
   Fine. So, in which release version we need to remove the WordCount case? 1.10 or 1.11? I prefer to remove it in next release version, when two other Mesos test  cases add. I don't have a strong opinion though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363313959
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multiple_submissions.sh
 ##########
 @@ -0,0 +1,54 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
 
 Review comment:
   For the previous version. It means to reduce the duration of the second job. So, yes, we can use the same duration now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363278943
 
 

 ##########
 File path: tools/travis/splits/split_container.sh
 ##########
 @@ -51,6 +51,7 @@ run_test "Run kubernetes test" "$END_TO_END_DIR/test-scripts/test_kubernetes_emb
 run_test "Run kubernetes session test" "$END_TO_END_DIR/test-scripts/test_kubernetes_session.sh"
 if [[ "${HADOOP_INTEGRATION}" = "with-hadoop" ]]; then
     run_test "Run Mesos WordCount test" "$END_TO_END_DIR/test-scripts/test_mesos_wordcount.sh"
 
 Review comment:
   After adding the new multiple submissions test, do we still need the word count test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363318382
 
 

 ##########
 File path: tools/travis/splits/split_container.sh
 ##########
 @@ -51,6 +51,7 @@ run_test "Run kubernetes test" "$END_TO_END_DIR/test-scripts/test_kubernetes_emb
 run_test "Run kubernetes session test" "$END_TO_END_DIR/test-scripts/test_kubernetes_session.sh"
 if [[ "${HADOOP_INTEGRATION}" = "with-hadoop" ]]; then
     run_test "Run Mesos WordCount test" "$END_TO_END_DIR/test-scripts/test_mesos_wordcount.sh"
 
 Review comment:
   I think we still need a "openbox" test case for deploying Flink on Mesos cluster. Anyway, it should be discussed in another ticket. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363258995
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multiple_submissions.sh
 ##########
 @@ -0,0 +1,54 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
+FIRST_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/first_out"
+SECOND_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/second_out"
+TEST_PROGRAM_JAR=$END_TO_END_DIR/flink-cli-test/target/PeriodicStreamingJob.jar
+CPUS=1
+
+function submit_job_return_jobid {
+    JOB_ID=$(docker exec -it mesos-master bash -c "${FLINK_DIR}/bin/flink run -d -p 1 ${TEST_PROGRAM_JAR} --durationInSecond ${FIRST_DURATION} --outputPath ${FIRST_OUTPUT_LOCATION}" \
+        | grep "Job has been submitted with JobID" | sed 's/.* //g' | tr -d '\r')
+    eval "$1=$JOB_ID"
+}
 
 Review comment:
   Is there any specific reason you  chose `eval` over:
   
   ```
   function submit_job {
       docker exec -it mesos-master bash -c "${FLINK_DIR}/bin/flink run -d -p 1 ${TEST_PROGRAM_JAR} --durationInSecond ${FIRST_DURATION} --outputPath ${FIRST_OUTPUT_LOCATION}" \
           | grep "Job has been submitted with JobID" | sed 's/.* //g' | tr -d '\r')
   }
   
   JOB1_ID=$(submit_job)
   ```
   
   ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142956703 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142956703) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r362701507
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multi_submission.sh
 ##########
 @@ -0,0 +1,58 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
+CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
 
 Review comment:
   Good catch. It's a redundant line.
   Yes, I have also considered that way. However, I've a concern makes me not choose that option. I think the auto-discovered value will free us from the the hardware limitation. For example, if we set it to 4, what if there is not enough cpu core in Travis or developer's environment? It's tricky to determine this value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142956703 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:MANUAL TriggerID:571021845
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:MANUAL TriggerID:571021845
   Hash:5a5c93dcead65507f3208c36ae0e23ebf395674a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4143 TriggerType:PUSH TriggerID:5a5c93dcead65507f3208c36ae0e23ebf395674a
   Hash:5a5c93dcead65507f3208c36ae0e23ebf395674a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143330543 TriggerType:PUSH TriggerID:5a5c93dcead65507f3208c36ae0e23ebf395674a
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142956703) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060) 
   * 9113fc48d92a1802fef17e51d9df71b2a1a70465 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143187251) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104) 
   * 5a5c93dcead65507f3208c36ae0e23ebf395674a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143330543) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4143) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363260627
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multiple_submissions.sh
 ##########
 @@ -0,0 +1,54 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
 
 Review comment:
   Sorry, didn't realize that you wanted to submit jobs with different arguments. Now, I don't see `SECOND_DURATION` being used. Can we use the same duration for both jobs?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r362700324
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multi_submission.sh
 ##########
 @@ -0,0 +1,58 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
+CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
+FIRST_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/first_out"
+SECOND_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/second_out"
+TEST_PROGRAM_JAR=$END_TO_END_DIR/flink-cli-test/target/PeriodicStreamingJob.jar
+if [[ "$OSTYPE" == "linux-gnu" ]]; then
+    CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
+elif [[ "$OSTYPE" == "darwin"* ]]; then
+    CPUS=$(sysctl -n hw.ncpu)
+else
+    echo "Could not verify the OS type."
+    exit 1
+fi
+
+
+mkdir -p "${TEST_DATA_DIR}"
+
+# There should be only one TaskManager with one slot; Thus, there are not enough resources to allocate a complete new set of slots for the second job.
+# To ensure the old slots are being reused.
+set_config_key "mesos.resourcemanager.tasks.cpus" "${CPUS}"
+
+start_flink_cluster_with_mesos
+
+JOB1_ID=$(docker exec -it mesos-master bash -c "${FLINK_DIR}/bin/flink run -d -p 1 ${TEST_PROGRAM_JAR} --durationInSecond ${FIRST_DURATION} --outputPath ${FIRST_OUTPUT_LOCATION}" \
+        | grep "Job has been submitted with JobID" | sed 's/.* //g' | tr -d '\r')
+
+wait_num_of_occurence_in_logs_mesos "switched from DEPLOYING to RUNNING" 1
 
 Review comment:
   I think it better to add this check to ensure the first job already occupy the slot and the second job need to wait for that slot to be free.
   If you think it's fragile, I'd like to harden this function. But so far, I do not figure out the fragile point here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r362492070
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multi_submission.sh
 ##########
 @@ -0,0 +1,58 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
+CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
 
 Review comment:
   Why assign the value here? `CPUS` will get re-assigned anyways, or the script won't continue.
   
   I suppose `CPUS` must match the auto-discovered value from the mesos agent. Do we actually have to determine the number of CPUs dynamically or can we use a constant that is independent from the hardware [1]? 
   
   [1] http://mesos.apache.org/documentation/attributes-resources/#predefined-uses-conventions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363278340
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -456,14 +456,21 @@ function wait_job_running {
   exit 1
 }
 
+function wait_job_terminal_state_mesos {
+  local job=$1
+  local expected_terminal_state=$2
+  wait_job_terminal_state $1 $2 "mesos-appmaster"
+}
+
 function wait_job_terminal_state {
   local job=$1
   local expected_terminal_state=$2
+  local log_file_name=${3:-standalonesession}
 
   echo "Waiting for job ($job) to reach terminal state $expected_terminal_state ..."
 
   while : ; do
-    local N=$(grep -o "Job $job reached globally terminal state .*" $FLINK_DIR/log/*standalonesession*.log | tail -1 || true)
+    local N=$(grep -o "Job $job reached globally terminal state .*" $FLINK_DIR/log/*$log_file_name*.log | tail -1 || true)
 
 Review comment:
   It's really a pity that we need a separate file pattern for the mesos appmaster but fixing that would be outside the scope of this ticket. However, I wonder if it makes sense to move the mesos flavored functions to a separate file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r362493313
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multi_submission.sh
 ##########
 @@ -0,0 +1,58 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
+CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
+FIRST_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/first_out"
+SECOND_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/second_out"
+TEST_PROGRAM_JAR=$END_TO_END_DIR/flink-cli-test/target/PeriodicStreamingJob.jar
+if [[ "$OSTYPE" == "linux-gnu" ]]; then
+    CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
+elif [[ "$OSTYPE" == "darwin"* ]]; then
+    CPUS=$(sysctl -n hw.ncpu)
+else
+    echo "Could not verify the OS type."
+    exit 1
+fi
+
+
+mkdir -p "${TEST_DATA_DIR}"
+
+# There should be only one TaskManager with one slot; Thus, there are not enough resources to allocate a complete new set of slots for the second job.
+# To ensure the old slots are being reused.
+set_config_key "mesos.resourcemanager.tasks.cpus" "${CPUS}"
+
+start_flink_cluster_with_mesos
+
+JOB1_ID=$(docker exec -it mesos-master bash -c "${FLINK_DIR}/bin/flink run -d -p 1 ${TEST_PROGRAM_JAR} --durationInSecond ${FIRST_DURATION} --outputPath ${FIRST_OUTPUT_LOCATION}" \
+        | grep "Job has been submitted with JobID" | sed 's/.* //g' | tr -d '\r')
+
+wait_num_of_occurence_in_logs_mesos "switched from DEPLOYING to RUNNING" 1
 
 Review comment:
   How important is this line? Grepping in logs is fragile.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363261744
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/docker-mesos-cluster/docker-compose.yml
 ##########
 @@ -55,6 +55,7 @@ services:
     volumes:
       - ${END_TO_END_DIR}:${END_TO_END_DIR}
     environment:
+      MESOS_RESOURCES: "cpus:1"
 
 Review comment:
   Ideally the number of cpus is configurable from within the test. If that is too much effort, I would be ok with adding a comment that this shouldn't be changed because `test_mesos_multiple_submissions.sh` relies on cpus being 1. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142956703 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142956703) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142956703 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143187251 TriggerType:MANUAL TriggerID:571021845
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104 TriggerType:MANUAL TriggerID:571021845
   Hash:5a5c93dcead65507f3208c36ae0e23ebf395674a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4143 TriggerType:PUSH TriggerID:5a5c93dcead65507f3208c36ae0e23ebf395674a
   Hash:5a5c93dcead65507f3208c36ae0e23ebf395674a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143330543 TriggerType:PUSH TriggerID:5a5c93dcead65507f3208c36ae0e23ebf395674a
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142956703) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060) 
   * 9113fc48d92a1802fef17e51d9df71b2a1a70465 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143187251) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4104) 
   * 5a5c93dcead65507f3208c36ae0e23ebf395674a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143330543) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4143) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142956703 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142956703) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL closed pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL closed pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363780918
 
 

 ##########
 File path: tools/travis/splits/split_container.sh
 ##########
 @@ -51,6 +51,7 @@ run_test "Run kubernetes test" "$END_TO_END_DIR/test-scripts/test_kubernetes_emb
 run_test "Run kubernetes session test" "$END_TO_END_DIR/test-scripts/test_kubernetes_session.sh"
 if [[ "${HADOOP_INTEGRATION}" = "with-hadoop" ]]; then
     run_test "Run Mesos WordCount test" "$END_TO_END_DIR/test-scripts/test_mesos_wordcount.sh"
 
 Review comment:
   I think each test case better not have multiple purposes so that we could find out the root cause quickly. I treat the WordCount case like a test for basic process of running Flink job on Mesos, including starting appmaster, running a simple job and verifying the correctness of result. I prefer to keep it in release 1.10, but I'm ok to remove it when the time overhead of E2E tests become severe.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r362766765
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multi_submission.sh
 ##########
 @@ -0,0 +1,58 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
+CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
+FIRST_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/first_out"
+SECOND_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/second_out"
+TEST_PROGRAM_JAR=$END_TO_END_DIR/flink-cli-test/target/PeriodicStreamingJob.jar
+if [[ "$OSTYPE" == "linux-gnu" ]]; then
+    CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
+elif [[ "$OSTYPE" == "darwin"* ]]; then
+    CPUS=$(sysctl -n hw.ncpu)
+else
+    echo "Could not verify the OS type."
+    exit 1
+fi
+
+
+mkdir -p "${TEST_DATA_DIR}"
+
+# There should be only one TaskManager with one slot; Thus, there are not enough resources to allocate a complete new set of slots for the second job.
+# To ensure the old slots are being reused.
+set_config_key "mesos.resourcemanager.tasks.cpus" "${CPUS}"
+
+start_flink_cluster_with_mesos
+
+JOB1_ID=$(docker exec -it mesos-master bash -c "${FLINK_DIR}/bin/flink run -d -p 1 ${TEST_PROGRAM_JAR} --durationInSecond ${FIRST_DURATION} --outputPath ${FIRST_OUTPUT_LOCATION}" \
+        | grep "Job has been submitted with JobID" | sed 's/.* //g' | tr -d '\r')
+
+wait_num_of_occurence_in_logs_mesos "switched from DEPLOYING to RUNNING" 1
 
 Review comment:
   I don't think the implementation is fragile. However, the concept of grepping logs is fragile because log messages are not part of the public API. Changing the log message or the log level [1] can break this test. Moreover, we would likely discover the breaking test very late because E2E tests are expensive to run, and only a subset of all tests are run on a pre-commit basis. If there is only a single slot in the entire cluster, one of the jobs will always have to wait for the other to complete. What difference does it make to deploy the second job later? Please correct me if I am missing something. 
   
   [1] https://github.com/apache/flink/blob/552a07677470d2df620aeb4e681e829f31d1526f/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java#L1528

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568451050
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit cc596f96fc38ff0235c6195fb39cab43d57861e4 (Mon Dec 23 11:33:36 UTC 2019)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15214).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363038375
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multi_submission.sh
 ##########
 @@ -0,0 +1,58 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
+CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
 
 Review comment:
   Agreed to set it to 1 in this test case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142956703 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060 TriggerType:PUSH TriggerID:c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0
   Hash:9113fc48d92a1802fef17e51d9df71b2a1a70465 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:9113fc48d92a1802fef17e51d9df71b2a1a70465
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   * c2cd715c56d3abc04ac50dca2e3ffbb9a7201dc0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142956703) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4060) 
   * 9113fc48d92a1802fef17e51d9df71b2a1a70465 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r362497483
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -629,15 +636,17 @@ function wait_oper_metric_num_in_records {
     done
 }
 
+function wait_num_of_occurence_in_logs_mesos() {
+    local text=$1
+    local number=$2
+    wait_num_of_occurence_in_logs $1 $2 "mesos-appmaster"
+}
+
 function wait_num_of_occurence_in_logs {
     local text=$1
     local number=$2
     local logs
-    if [ -z "$3" ]; then
-        logs="standalonesession"
-    else
-        logs="$3"
-    fi
+    local logs=${3-standalonesession}
 
 Review comment:
   Very nice simplification.
   
   nit: So far we have always used the `${3:-standalonesession}` syntax for default values in this project.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142858868 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   Hash:4f0363bb7f136b253490c4bc562e12bcdac9200a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043 TriggerType:PUSH TriggerID:4f0363bb7f136b253490c4bc562e12bcdac9200a
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   * 4f0363bb7f136b253490c4bc562e12bcdac9200a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142858868) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4043) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363564488
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/docker-mesos-cluster/docker-compose.yml
 ##########
 @@ -55,6 +55,7 @@ services:
     volumes:
       - ${END_TO_END_DIR}:${END_TO_END_DIR}
     environment:
+      MESOS_RESOURCES: "cpus:1"
 
 Review comment:
   I've implemented this in the latest version. Please take a look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-570989496
 
 
   Travis gives green light to relevant test. https://travis-ci.org/KarmaGYZ/flink/builds/633110748

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#issuecomment-568454903
 
 
   <!--
   Meta data
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   Hash:cc596f96fc38ff0235c6195fb39cab43d57861e4 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142105563 TriggerType:PUSH TriggerID:cc596f96fc38ff0235c6195fb39cab43d57861e4
   -->
   ## CI report:
   
   * cc596f96fc38ff0235c6195fb39cab43d57861e4 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142105563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3863) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10666: [FLINK-15214] Introduce multiple submission e2e test
URL: https://github.com/apache/flink/pull/10666#discussion_r363038355
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_mesos_multi_submission.sh
 ##########
 @@ -0,0 +1,58 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+set -o pipefail
+
+source "$(dirname "$0")"/common.sh
+source "$(dirname "$0")"/common_mesos_docker.sh
+
+FIRST_DURATION=15
+SECOND_DURATION=5
+CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
+FIRST_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/first_out"
+SECOND_OUTPUT_LOCATION="${TEST_DATA_DIR}/out/second_out"
+TEST_PROGRAM_JAR=$END_TO_END_DIR/flink-cli-test/target/PeriodicStreamingJob.jar
+if [[ "$OSTYPE" == "linux-gnu" ]]; then
+    CPUS=$(lscpu | grep "^CPU(s):" | awk '{print $2}')
+elif [[ "$OSTYPE" == "darwin"* ]]; then
+    CPUS=$(sysctl -n hw.ncpu)
+else
+    echo "Could not verify the OS type."
+    exit 1
+fi
+
+
+mkdir -p "${TEST_DATA_DIR}"
+
+# There should be only one TaskManager with one slot; Thus, there are not enough resources to allocate a complete new set of slots for the second job.
+# To ensure the old slots are being reused.
+set_config_key "mesos.resourcemanager.tasks.cpus" "${CPUS}"
+
+start_flink_cluster_with_mesos
+
+JOB1_ID=$(docker exec -it mesos-master bash -c "${FLINK_DIR}/bin/flink run -d -p 1 ${TEST_PROGRAM_JAR} --durationInSecond ${FIRST_DURATION} --outputPath ${FIRST_OUTPUT_LOCATION}" \
+        | grep "Job has been submitted with JobID" | sed 's/.* //g' | tr -d '\r')
+
+wait_num_of_occurence_in_logs_mesos "switched from DEPLOYING to RUNNING" 1
 
 Review comment:
   Fair enough.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services