You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by ud...@apache.org on 2017/06/09 20:13:50 UTC
[16/27] geode git commit: GEODE-3050: prevent empty dat files
GEODE-3050: prevent empty dat files
Move creation of dat files to test methods to avoid overwriting
full dat file from other test.
Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/46399d4b
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/46399d4b
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/46399d4b
Branch: refs/heads/feature/GEODE-3023
Commit: 46399d4bf70cdbae89ef11858d65fa7191c4db93
Parents: 3fa8bd4
Author: Kirk Lund <kl...@apache.org>
Authored: Wed Jun 7 16:55:54 2017 -0700
Committer: Udo Kohlmeyer <uk...@pivotal.io>
Committed: Fri Jun 9 13:12:03 2017 -0700
----------------------------------------------------------------------
.../codeAnalysis/AnalyzeSerializablesJUnitTest.java | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/geode/blob/46399d4b/geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java b/geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
index dc73f04..2ba11a2 100644
--- a/geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTest.java
@@ -89,11 +89,6 @@ public class AnalyzeSerializablesJUnitTest {
this.expectedSerializables = loadClassesAndVariables(expectedSerializablesFile);
Collections.sort(this.expectedSerializables);
-
- // setup empty actual files
-
- this.actualDataSerializablesFile = createEmptyFile("actualDataSerializables.dat");
- this.actualSerializablesFile = createEmptyFile("actualSerializables.dat");
}
/**
@@ -107,6 +102,10 @@ public class AnalyzeSerializablesJUnitTest {
public void testDataSerializables() throws Exception {
System.out.println(this.testName.getMethodName() + " starting");
+ this.actualDataSerializablesFile = createEmptyFile("actualDataSerializables.dat");
+ System.out.println(this.testName.getMethodName() + " actualDataSerializablesFile="
+ + this.actualDataSerializablesFile.getAbsolutePath());
+
List<ClassAndMethods> actualDataSerializables = findToDatasAndFromDatas();
storeClassesAndMethods(actualDataSerializables, this.actualDataSerializablesFile);
@@ -128,6 +127,10 @@ public class AnalyzeSerializablesJUnitTest {
public void testSerializables() throws Exception {
System.out.println(this.testName.getMethodName() + " starting");
+ this.actualSerializablesFile = createEmptyFile("actualSerializables.dat");
+ System.out.println(this.testName.getMethodName() + " actualSerializablesFile="
+ + this.actualSerializablesFile.getAbsolutePath());
+
List<ClassAndVariables> actualSerializables = findSerializables();
storeClassesAndVariables(actualSerializables, this.actualSerializablesFile);