[GitHub] [bookkeeper] horizonzy commented on pull request #4038: Improve DefaultEntryLogger read performance.

["horizonzy (via GitHub)" <gi...@apache.org>]

horizonzy commented on PR #4038:
URL: https://github.com/apache/bookkeeper/pull/4038#issuecomment-1652738334

   > Good idea, great results.
   > 
   > Can you please check that these "Bookie Tests" failures aren't related the change:
   > 
   > ```
   > Error:  Errors: 
   > Error:  org.apache.bookkeeper.bookie.DefaultEntryLogTest.testAppendLedgersMapOnCacheRemoval
   > Error:    Run 1: DefaultEntryLogTest.testAppendLedgersMapOnCacheRemoval:1223 » IO Not all ledge...
   > Error:    Run 2: DefaultEntryLogTest.testAppendLedgersMapOnCacheRemoval:1223 » IO Not all ledge...
   > Error:    Run 3: DefaultEntryLogTest.testAppendLedgersMapOnCacheRemoval:1223 » IO Not all ledge...
   > [INFO] 
   > Error:  org.apache.bookkeeper.bookie.storage.ldb.DbLedgerStorageTest.testEntriesOutOfOrderWithFlush
   > Error:    Run 1: DbLedgerStorageTest.testEntriesOutOfOrderWithFlush:400 » IO Bad entry read fro...
   > Error:    Run 2: DbLedgerStorageTest.testEntriesOutOfOrderWithFlush:400 » IO Bad entry read fro...
   > Error:    Run 3: DbLedgerStorageTest.testEntriesOutOfOrderWithFlush:400 » IO Bad entry read fro...
   > [INFO] 
   > Warning:  Flakes: 
   > Warning:  InterleavedLedgerStorageTest.testConsistencyCheckConcurrentGC
   > [INFO]   Run 1: PASS
   > Error:    Run 2: expected:<0> but was:<8354>
   > Error:    Run 3: expected:<0> but was:<7255>
   > Error:    Run 4: expected:<0> but was:<7712>
   > ```
   > 
   > I'll restart the job to see if these are flaps though I don't think these tests flapped before.
   
   I have checked the testAppendLedgersMapOnCacheRemoval and testEntriesOutOfOrderWithFlush. The problem is that the BufferedReadChannel and BufferedLogChannel share the same FileChannel. When the BufferedReadChannel finishes reading the fileSize, the BufferedLogChannel writes new data into the file. I will verify if this situation exists. In theory, the FileChannel read by the BufferedLogChannel should not write any new data.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org