You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/23 02:24:20 UTC
[GitHub] nswamy commented on a change in pull request #12913: fix the Scala
URL issue for downloading data in scripts
nswamy commented on a change in pull request #12913: fix the Scala URL issue for downloading data in scripts
URL: https://github.com/apache/incubator-mxnet/pull/12913#discussion_r227201232
##########
File path: scala-package/examples/scripts/infer/imageclassifier/get_resnet_18_data.sh
##########
@@ -37,5 +37,5 @@ if [ ! -f "$data_path" ]; then
wget https://s3.us-east-2.amazonaws.com/scala-infer-models/resnet-18/resnet-18-symbol.json -P $data_path
wget https://s3.us-east-2.amazonaws.com/scala-infer-models/resnet-18/resnet-18-0000.params -P $data_path
wget https://s3.us-east-2.amazonaws.com/scala-infer-models/resnet-18/synset.txt -P $data_path
- wget https://s3.amazonaws.com/model-server/inputs/kitten.jpg -P $image_path
+ wget https://s3.us-east-2.amazonaws.com/mxnet-scala/scala-example-ci/resnet152/kitten.jpg -P $image_path
Review comment:
its ok for now, I agree with @piyushghai that we need to make sure the same models work across all language bindings, otherwise it is confusing to users why we are using different models in different bindings and lose their trust.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services