You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@artemis.apache.org by "gtully (via GitHub)" <gi...@apache.org> on 2026/06/16 14:23:34 UTC
[PR] ARTEMIS-6117 allow configuration of journal file lock check period [artemis]
gtully opened a new pull request, #6517:
URL: https://github.com/apache/artemis/pull/6517
AssistedBy: Claude
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-6117 allow configuration of journal file lock check period [artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #6517:
URL: https://github.com/apache/artemis/pull/6517#issuecomment-4737222839
Currently have 2 distinct file-lock implementations:
- `org.apache.activemq.artemis.core.server.impl.FileLockNodeManager`
- `org.apache.activemq.artemis.lockmanager.file.FileBasedLockManager`
In my opinion, we should consolidate on the lock-manager one, but we'll need to implement some stuff that it's lacking compared to the other one.
In any case, the configuration is done completely differently so I'm OK with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-6117 allow configuration of journal file lock check period [artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #6517:
URL: https://github.com/apache/artemis/pull/6517#issuecomment-4803501266
actually... I saw where lockMonitorTimeout was added.. that's confusing with Lock coordinator.. this is specific to journal, right. what about JournalLockMonitorTimeout and JournalLockMonitorMaxRetries?
I reckon ideally this should have its section in configuration for journal-config.. but that's the way it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-6117 allow configuration of journal file lock check period [artemis]
Posted by "gtully (via GitHub)" <gi...@apache.org>.
gtully merged PR #6517:
URL: https://github.com/apache/artemis/pull/6517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-6117 allow configuration of journal file lock check period [artemis]
Posted by "gtully (via GitHub)" <gi...@apache.org>.
gtully commented on PR #6517:
URL: https://github.com/apache/artemis/pull/6517#issuecomment-4740954557
agree, if the broker is busy it may see an io error before the lock monitor does. But if those errors can be relayed to a client via failed sends/acks that could be ok. We would need to avoid the shutdown up to some threshold.
If we know that the underlying file system has a recovery time of say 5s, and will block during an outage.
What existing configuration options do we have to around journal IO to make it more tolerant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-6117 allow configuration of journal file lock check period [artemis]
Posted by "gtully (via GitHub)" <gi...@apache.org>.
gtully commented on PR #6517:
URL: https://github.com/apache/artemis/pull/6517#issuecomment-4750194498
Relating to blocking writes, the journal-file-open-timeout defaults to 5s, that would cause a critical io error if exceeded. To match a 5s MTR, that would need to be increased otherwise it could trip before the lock monitor.
<journal-file-open-timeout>15</journal-file-open-timeout>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-6117 allow configuration of journal file lock check period [artemis]
Posted by "gtully (via GitHub)" <gi...@apache.org>.
gtully commented on PR #6517:
URL: https://github.com/apache/artemis/pull/6517#issuecomment-4719821816
feedback required on the names. do we want to limit to journal-file or leave open to be potentially used by the distributed file lock? The existing JournalLockAcquisitionTimeout is an existing related entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-6117 allow configuration of journal file lock check period [artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #6517:
URL: https://github.com/apache/artemis/pull/6517#issuecomment-4736927233
I looked into this from the functionality POV and I think it's okay.
However, I know where this is coming from, and I think the server will still shutdown on critical error when the device (or network) is offline. This is only useful if the server is completely idle and even then I'm not sure if the OS will keep the file handles active in case of a network outage on a NFS.
This may be okay if the server is idle when the network outage happens, but even that would need to be tested I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-6117 allow configuration of journal file lock check period [artemis]
Posted by "gtully (via GitHub)" <gi...@apache.org>.
gtully commented on PR #6517:
URL: https://github.com/apache/artemis/pull/6517#issuecomment-4809051088
agree, thanks, prefixed with journal- and added related doc references
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org