You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/30 11:21:27 UTC

[GitHub] [spark] cxzl25 opened a new pull request #26323: [SPARK-29657][CORE] Iterator spill supporting radix sort with null prefix

cxzl25 opened a new pull request #26323: [SPARK-29657][CORE] Iterator spill supporting radix sort with null prefix
URL: https://github.com/apache/spark/pull/26323
 
 
   ### What changes were proposed in this pull request?
   Support ```ChainedIterator``` with ```SortedIterator``` spill
   
   ### Why are the changes needed?
   In the case of radix sort, when the ```insertRecord``` part of the keyPrefix is null, the iterator type returned by ```getSortedIterator``` is ```ChainedIterator```.
   Currently ```ChainedIterator``` does not support spill, causing ```UnsafeExternalSorter``` to take up a lot of execution memory, ```allocatePage``` fails, throw ```SparkOutOfMemoryError``` Unable to acquire xxx bytes of memory, got 0
   
   ### Does this PR introduce any user-facing change?
   No
   
   ### How was this patch tested?
   add ut
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org