[GitHub] [arrow] xxlaykxx opened a new pull request, #36350: Added creating MapWriter in ComplexWriter.

["xxlaykxx (via GitHub)" <gi...@apache.org>]

xxlaykxx opened a new pull request, #36350:
URL: https://github.com/apache/arrow/pull/36350

   Added new method rootAsMap() to ComplexWriter and implement it in ComplexWriterImpl for supporting map type.
   
   Previously in dremio side:
   
   When i trying to return map like @output ComplexWrite
   with this code:
   
   org.apache.arrow.vector.complex.writer.BaseWriter.MapWriter mapWriter = out.rootAsList().map(false);
   
   mapWriter.startMap();
   for (java.util.Map.Entry<java.lang.Integer, java.lang.Integer> element : map.entrySet()) {
       mapWriter.startEntry();
       mapWriter.key().integer().writeInt((Integer) element.getKey());
       mapWriter.value().integer().writeInt((Integer) element.getValue());
       mapWriter.endEntry();
   }
   mapWriter.endMap();
   It use UnionMapWriter and generate schema like:
   EXPR$0: Map(false)<$data$: Union(Sparse, [1, 39])<struct: Struct<key: Int(32, true) not null, value: Int(32, true) not null> not null, map: Map(false)<entries: Struct<key: Int(32, true) not null, value: Int(32, true)> not null>>>
   But in OutputDerivation impl class where i should create output Complete type
   
   List<Field> children = Arrays.asList( CompleteType.INT.toField("key", false), CompleteType.INT.toField("value", false));
   return new CompleteType(CompleteType.MAP.getType(), CompleteType.struct(children).toField(MapVector.DATA_VECTOR_NAME, false));
   (This is only one valid case, because MapVector.initializeChildrenFromFields())
   return
   EXPR$0::map<key::int32, value::int32> I found a place where it start using union - PromotableWriter.promoteToUnion.
   And in the end i have
   
   SCHEMA_CHANGE ERROR: Schema changed during projection. Schema was 
   schema(EXPR$0::map<key::int32, value::int32>)
    but then changed to 
   schema(EXPR$0::map<struct::struct<key::int32, value::int32>, map::map<key::int32, value::int32>>)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #36350: Added creating MapWriter in ComplexWriter.

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on PR #36350:
URL: https://github.com/apache/arrow/pull/36350#issuecomment-1611143995

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   In the case of PARQUET issues on JIRA the title also supports:
   
       PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] xxlaykxx closed pull request #36350: Added creating MapWriter in ComplexWriter.

["xxlaykxx (via GitHub)" <gi...@apache.org>]

xxlaykxx closed pull request #36350: Added creating MapWriter in ComplexWriter.
URL: https://github.com/apache/arrow/pull/36350


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org