You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/10/02 09:22:54 UTC
[GitHub] [incubator-yunikorn-core] chia7712 opened a new pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
chia7712 opened a new pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328
### What is this PR for?
We are integrating yunikorn with monitor system through application REST APIs. The application rest APIs is useful but it lacks three important information.
1. elapsed time of a application
2. the allocations to use when running (the `usedResource` is reset to zero when the application is terminated)
3. user name (It can enable us to trace the application for specific user, but I am fire to remove this if it is a security issue.)
Also, the application REST APIs need to be more flexible. For example, it should support following queries:
1. applicationState
2. user name (will be added)
This issue is related to following REST APIs.
1. `/ws/v1/apps`
2. `/ws/v1/partition/{partition}/queue/{queue}/applications`
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Update web docs of application REST APIs
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-870
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#discussion_r817957792
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -1193,6 +1202,19 @@ func (sa *Application) UnSetQueue() {
sa.Lock()
defer sa.Unlock()
sa.queue = nil
+ now := time.Now()
+ sa.finishedTime = &now
+}
+
+// FinishedTimeInUnixNano return the finished time if this application is terminated. Otherwise, it returns null
+func (sa *Application) FinishedTimeInUnixNano() *int64 {
Review comment:
We might want to support this for other time values also.
Can we generalise this into a utility function? Bases on a time object and use time.IsZero():
```
func ZeroTimeInUnixNano(t time.Time) *int64 {
if t.IsZero() {
return nil
}
tInt := t.UnixNano()
return &tInt
}
```
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -1193,6 +1202,19 @@ func (sa *Application) UnSetQueue() {
sa.Lock()
defer sa.Unlock()
sa.queue = nil
+ now := time.Now()
+ sa.finishedTime = &now
Review comment:
we should leverage IsZero() for unset time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#issuecomment-932721441
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#328](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff5821a) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/f8f4c4bb9f0323697e28ac83610fd14d1dcc6f1a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8f4c4b) will **decrease** coverage by `1.82%`.
> The diff coverage is `77.41%`.
> :exclamation: Current head ff5821a differs from pull request most recent head eb68b61. Consider uploading reports for the commit eb68b61 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
- Coverage 69.41% 67.59% -1.83%
==========================================
Files 66 63 -3
Lines 9318 6054 -3264
==========================================
- Hits 6468 4092 -2376
+ Misses 2608 1746 -862
+ Partials 242 216 -26
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `56.67% <45.45%> (-0.72%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `75.58% <95.00%> (+2.48%)` | :arrow_up: |
| [pkg/metrics/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21ldHJpY3MvcXVldWUuZ28=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [pkg/plugins/plugins.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbnMvcGx1Z2lucy5nbw==) | `72.72% <0.00%> (-27.28%)` | :arrow_down: |
| [pkg/common/configs/configtestutils.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3Rlc3R1dGlscy5nbw==) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `16.74% <0.00%> (-15.44%)` | :arrow_down: |
| [pkg/scheduler/objects/application\_state.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uX3N0YXRlLmdv) | `93.40% <0.00%> (-6.60%)` | :arrow_down: |
| [pkg/scheduler/trace\_utils.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci90cmFjZV91dGlscy5nbw==) | `39.13% <0.00%> (-4.62%)` | :arrow_down: |
| [pkg/common/security/usergroup.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zZWN1cml0eS91c2VyZ3JvdXAuZ28=) | `81.81% <0.00%> (-3.90%)` | :arrow_down: |
| [pkg/scheduler/objects/template/template.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3RlbXBsYXRlL3RlbXBsYXRlLmdv) | `64.10% <0.00%> (-2.57%)` | :arrow_down: |
| ... and [58 more](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f8f4c4b...eb68b61](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#issuecomment-932721441
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#328](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2946742) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/f8f4c4bb9f0323697e28ac83610fd14d1dcc6f1a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8f4c4b) will **increase** coverage by `0.17%`.
> The diff coverage is `83.72%`.
> :exclamation: Current head 2946742 differs from pull request most recent head 2f19948. Consider uploading reports for the commit 2f19948 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 69.41% 69.58% +0.17%
==========================================
Files 66 66
Lines 9318 9348 +30
==========================================
+ Hits 6468 6505 +37
+ Misses 2608 2601 -7
Partials 242 242
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.69% <76.47%> (+0.30%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `75.30% <88.46%> (+2.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f8f4c4b...2f19948](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#issuecomment-932721441
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#328](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f19948) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/59c228177c48516438b391e0a98b7f9393b28ec3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59c2281) will **increase** coverage by `0.23%`.
> The diff coverage is `83.72%`.
> :exclamation: Current head 2f19948 differs from pull request most recent head bf8f6f9. Consider uploading reports for the commit bf8f6f9 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 69.35% 69.58% +0.23%
==========================================
Files 66 66
Lines 9365 9348 -17
==========================================
+ Hits 6495 6505 +10
+ Misses 2627 2601 -26
+ Partials 243 242 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.69% <76.47%> (+0.18%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `75.30% <88.46%> (+1.78%)` | :arrow_up: |
| [pkg/webservice/state\_dump.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2Uvc3RhdGVfZHVtcC5nbw==) | `80.12% <0.00%> (-0.13%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.17% <0.00%> (-0.10%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [59c2281...bf8f6f9](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#issuecomment-932721441
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#328](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff5821a) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/5a1c19e280f66d6cb4fc206a675116260d6f2ff1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a1c19e) will **increase** coverage by `4.12%`.
> The diff coverage is `68.28%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 63.46% 67.59% +4.12%
==========================================
Files 60 63 +3
Lines 5220 6054 +834
==========================================
+ Hits 3313 4092 +779
+ Misses 1747 1746 -1
- Partials 160 216 +56
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/metrics/init.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21ldHJpY3MvaW5pdC5nbw==) | `62.96% <ø> (ø)` | |
| [pkg/scheduler/drf\_preemption\_policy.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9kcmZfcHJlZW1wdGlvbl9wb2xpY3kuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/scheduler/nodes\_usage\_monitor.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9ub2Rlc191c2FnZV9tb25pdG9yLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/scheduler/objects/allocation.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FsbG9jYXRpb24uZ28=) | `100.00% <ø> (ø)` | |
| [pkg/scheduler/objects/node\_iterator.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGVfaXRlcmF0b3IuZ28=) | `100.00% <ø> (ø)` | |
| [pkg/scheduler/objects/sorters.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3NvcnRlcnMuZ28=) | `100.00% <ø> (ø)` | |
| [pkg/webservice/webservice.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2Uvd2Vic2VydmljZS5nbw==) | `32.25% <ø> (+19.35%)` | :arrow_up: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `16.74% <24.19%> (+10.47%)` | :arrow_up: |
| [pkg/metrics/metrics\_collector.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21ldHJpY3MvbWV0cmljc19jb2xsZWN0b3IuZ28=) | `64.51% <45.00%> (-9.40%)` | :arrow_down: |
| [pkg/metrics/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21ldHJpY3Mvc2NoZWR1bGVyLmdv) | `58.92% <49.33%> (-2.66%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9da9dae...ff5821a](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#issuecomment-932721441
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#328](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f19948) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/f8f4c4bb9f0323697e28ac83610fd14d1dcc6f1a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8f4c4b) will **increase** coverage by `0.17%`.
> The diff coverage is `83.72%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 69.41% 69.58% +0.17%
==========================================
Files 66 66
Lines 9318 9348 +30
==========================================
+ Hits 6468 6505 +37
+ Misses 2608 2601 -7
Partials 242 242
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.69% <76.47%> (+0.30%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `75.30% <88.46%> (+2.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f8f4c4b...2f19948](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#discussion_r817942760
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -77,6 +78,7 @@ type Application struct {
execTimeout time.Duration // execTimeout for the application run
placeholderTimer *time.Timer // placeholder replace timer
gangSchedulingStyle string // gang scheduling style can be hard (after timeout we fail the application), or soft (after timeeout we schedule it as a normal application)
+ finishedTime *time.Time // the time of finishing this application. the default value is nil
Review comment:
see comment below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#discussion_r817970159
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -1193,6 +1202,19 @@ func (sa *Application) UnSetQueue() {
sa.Lock()
defer sa.Unlock()
sa.queue = nil
+ now := time.Now()
+ sa.finishedTime = &now
+}
+
+// FinishedTimeInUnixNano return the finished time if this application is terminated. Otherwise, it returns null
+func (sa *Application) FinishedTimeInUnixNano() *int64 {
Review comment:
the conversion into the `*int64` can then be made as part of the DAO creation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#issuecomment-932721441
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#328](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f19948) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/59c228177c48516438b391e0a98b7f9393b28ec3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59c2281) will **increase** coverage by `0.23%`.
> The diff coverage is `83.72%`.
> :exclamation: Current head 2f19948 differs from pull request most recent head 3bcfe95. Consider uploading reports for the commit 3bcfe95 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 69.35% 69.58% +0.23%
==========================================
Files 66 66
Lines 9365 9348 -17
==========================================
+ Hits 6495 6505 +10
+ Misses 2627 2601 -26
+ Partials 243 242 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.69% <76.47%> (+0.18%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `75.30% <88.46%> (+1.78%)` | :arrow_up: |
| [pkg/webservice/state\_dump.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2Uvc3RhdGVfZHVtcC5nbw==) | `80.12% <0.00%> (-0.13%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `32.17% <0.00%> (-0.10%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [59c2281...3bcfe95](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] chia7712 commented on a change in pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#discussion_r815296623
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -77,6 +78,7 @@ type Application struct {
execTimeout time.Duration // execTimeout for the application run
placeholderTimer *time.Timer // placeholder replace timer
gangSchedulingStyle string // gang scheduling style can be hard (after timeout we fail the application), or soft (after timeeout we schedule it as a normal application)
+ finishedTime *time.Time // the time of finishing this application. the default value is nil
Review comment:
@wilfred-s I use `nil` to replace zero time, since `nil` implies there is no `finishedTime` currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s closed pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#issuecomment-932721441
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#328](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2946742) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/f8f4c4bb9f0323697e28ac83610fd14d1dcc6f1a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8f4c4b) will **increase** coverage by `0.17%`.
> The diff coverage is `83.72%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 69.41% 69.58% +0.17%
==========================================
Files 66 66
Lines 9318 9348 +30
==========================================
+ Hits 6468 6505 +37
+ Misses 2608 2601 -7
Partials 242 242
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.69% <76.47%> (+0.30%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `75.30% <88.46%> (+2.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f8f4c4b...2946742](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] chia7712 commented on pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#issuecomment-1051974822
The response of `ws/v1/apps` is shown below.
```json
[
{
"applicationID": "spark-513ec7450ab34c81957c7bea0d8c5d2a",
"usedResource": "[]",
"maxUsedResource": "[]",
"partition": "default",
"queueName": "root.infinite",
"submissionTime": 1645871481994982370,
"finishedTime": null,
"allocations": [],
"applicationState": "New",
"user": "nobody"
},
{
"applicationID": "spark-2f6d5babe1dd42478f57d9e965af2411",
"usedResource": "[memory:0 vcore:0]",
"maxUsedResource": "[memory:3222 vcore:5000]",
"partition": "default",
"queueName": "root.infinite",
"submissionTime": 1645871347893002178,
"finishedTime": 1645871391609017573,
"allocations": [],
"applicationState": "Completed",
"user": "nobody"
}
]
```
The first application has `null` finishedTime since it is not finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#issuecomment-932721441
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#328](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3bcfe95) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/59c228177c48516438b391e0a98b7f9393b28ec3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59c2281) will **increase** coverage by `0.11%`.
> The diff coverage is `71.11%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 69.35% 69.46% +0.11%
==========================================
Files 66 66
Lines 9365 9397 +32
==========================================
+ Hits 6495 6528 +33
+ Misses 2627 2626 -1
Partials 243 243
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlscy5nbw==) | `71.01% <0.00%> (-6.77%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `57.65% <69.23%> (+0.14%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `75.67% <88.46%> (+2.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [59c2281...3bcfe95](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] chia7712 commented on pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#issuecomment-1057745798
> Can you also confirm that this works for the new API call path, I checked and it looks like it does just want a confirmation.
I have checked related call path, and there is nothing weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#issuecomment-1050372117
@chia7712 any update on this one. We seem to be so close to getting this done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #328: [YUNIKORN-870] Enhance application-related REST APIs
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#issuecomment-932721441
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#328](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff5821a) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/f8f4c4bb9f0323697e28ac83610fd14d1dcc6f1a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8f4c4b) will **decrease** coverage by `1.82%`.
> The diff coverage is `77.41%`.
> :exclamation: Current head ff5821a differs from pull request most recent head 2946742. Consider uploading reports for the commit 2946742 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
- Coverage 69.41% 67.59% -1.83%
==========================================
Files 66 63 -3
Lines 9318 6054 -3264
==========================================
- Hits 6468 4092 -2376
+ Misses 2608 1746 -862
+ Partials 242 216 -26
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `56.67% <45.45%> (-0.72%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `75.58% <95.00%> (+2.48%)` | :arrow_up: |
| [pkg/metrics/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21ldHJpY3MvcXVldWUuZ28=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [pkg/plugins/plugins.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbnMvcGx1Z2lucy5nbw==) | `72.72% <0.00%> (-27.28%)` | :arrow_down: |
| [pkg/common/configs/configtestutils.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3Rlc3R1dGlscy5nbw==) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `16.74% <0.00%> (-15.44%)` | :arrow_down: |
| [pkg/scheduler/objects/application\_state.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uX3N0YXRlLmdv) | `93.40% <0.00%> (-6.60%)` | :arrow_down: |
| [pkg/scheduler/trace\_utils.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci90cmFjZV91dGlscy5nbw==) | `39.13% <0.00%> (-4.62%)` | :arrow_down: |
| [pkg/common/security/usergroup.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zZWN1cml0eS91c2VyZ3JvdXAuZ28=) | `81.81% <0.00%> (-3.90%)` | :arrow_down: |
| [pkg/scheduler/objects/template/template.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3RlbXBsYXRlL3RlbXBsYXRlLmdv) | `64.10% <0.00%> (-2.57%)` | :arrow_down: |
| ... and [58 more](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f8f4c4b...2946742](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/328?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org