You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/11 08:31:07 UTC

[GitHub] [arrow] AlenkaF commented on a diff in pull request #14350: ARROW-17891: [Docs][Python] Update and sync Win section of the developers/python page

AlenkaF commented on code in PR #14350:
URL: https://github.com/apache/arrow/pull/14350#discussion_r992006087


##########
docs/source/developers/python.rst:
##########
@@ -509,7 +509,7 @@ First, starting from a fresh clone of Apache Arrow:
          --file arrow\ci\conda_env_cpp.txt ^

Review Comment:
   I would add proposed changes in the scope of https://issues.apache.org/jira/browse/ARROW-17949
   
   - The C++ documentation needs to be updated https://arrow.apache.org/docs/dev/developers/cpp/windows.html#building-with-ninja-and-clcache
   - Python dev page can be updated with adding `ccache` (manually or to `conda_env_cpp.txt`), some CMake flags would also be needed (`ARROW_USE_CCACHE` and maybe [`ARROW_USE_SCCACHE`](https://github.com/apache/arrow/blob/89c0214fa43f8d1bf2e19e3bae0fc3009df51e15/cpp/cmake_modules/DefineOptions.cmake#L174-L175)?) plus I would test it locally so that nothing is missing.
   
   What do you think?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org