You are viewing a plain text version of this content. The canonical link for it is here.

Posted to solr-dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2009/11/06 01:57:32 UTC

[jira] Updated: (SOLR-1543) StreamingUpdateSolrServer threading bug

     [ https://issues.apache.org/jira/browse/SOLR-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-1543:
-------------------------------

    Attachment: SOLR-1543.patch

This patch most likely does not fix the problem (I don't even know how to reproduce the problem at this point).  But it does:
 - unlock the lock in a finally block
 - fix thread visibility of the lock by making it volatile
 - change the lock in each runner to be a countdown latch since the only purpose appears to be to wait for the runner to stop.  This fixes a race condition where previously the lock/unlock pair in blockUntilFinished() could possibly execute *before* the runner itself locks the lock.

There are other race conditions and thread safety problems I see, but I'm not sure if any are serious or not.

> StreamingUpdateSolrServer threading bug
> ---------------------------------------
>
>                 Key: SOLR-1543
>                 URL: https://issues.apache.org/jira/browse/SOLR-1543
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Yonik Seeley
>         Attachments: SOLR-1543.patch
>
>
> StreamingUpdateSolrServer - indexing process stops in a couple of hours
> http://search.lucidimagination.com/search/document/352d3c8cd3bbc8cb

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.