[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8644: Fix Kinesis resharding issues

[GitBox <gi...@apache.org>]

jon-wei commented on a change in pull request #8644: Fix Kinesis resharding issues
URL: https://github.com/apache/incubator-druid/pull/8644#discussion_r332669880
 
 

 ##########
 File path: extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisor.java
 ##########
 @@ -219,7 +234,34 @@ protected int getTaskGroupIdForPartition(String partitionId)
       partitionIds.add(partitionId);
     }
 
-    return partitionIds.indexOf(partitionId) % spec.getIoConfig().getTaskCount();
+    Integer intForModulo = extractShardNumberFromShardId(partitionId);
+    if (intForModulo == null) {
+      intForModulo = getHashIntFromShardId(partitionId);
+    }
+
+    return Math.abs(intForModulo % spec.getIoConfig().getTaskCount());
+  }
+
+  private Integer extractShardNumberFromShardId(String shardId)
+  {
+    String numOnly = StringUtils.replace(shardId, "shardId-", "");
+    try {
+      Long shardNum = DimensionHandlerUtils.convertObjectToLong(numOnly);
+      if (shardNum != null) {
+        return shardNum.intValue();
+      } else {
+        return null;
+      }
+    }
+    catch (Exception e) {
+      return null;
+    }
+  }
+
+  private int getHashIntFromShardId(String shardId)
+  {
+    HashCode hashCode = HASH_FUNCTION.hashString(shardId, StandardCharsets.UTF_8);
 
 Review comment:
   Hm, I liked using the shard number if possible since it would be fairly straightforward for a human user to calculate the task group if needed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org