You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hongtu Zang <ho...@tcloudcomputing.com> on 2013/08/05 17:20:42 UTC

Review Request 13268: fix bug CLOUDSTACK-4088 cloudstack will stop and delete vm which not belongs to cs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13268/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek, edison su, and mice xia.


Bugs: CLOUDSTACK-4088


Repository: cloudstack-git


Description
-------

fullSync will check if the vm is following CS naming and will stop the vms which are not belongs to CS and having the same name with CS vms.
but in deltaSync it will stop all vms not belongs to CS.
It is unreasonable to stop or remove a vm that not belongs to CS.


Diffs
-----

  server/src/com/cloud/vm/VirtualMachineManagerImpl.java b33ee49 

Diff: https://reviews.apache.org/r/13268/diff/


Testing
-------

vm which not belongs to CS will not removed or stopped


Thanks,

Hongtu Zang


Re: Review Request 13268: fix bug CLOUDSTACK-4088 cloudstack will stop and delete vm which not belongs to cs

Posted by Hongtu Zang <ho...@tcloudcomputing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13268/
-----------------------------------------------------------

(Updated Aug. 5, 2013, 3:59 p.m.)


Review request for cloudstack, Abhinandan Prateek, edison su, and mice xia.


Bugs: CLOUDSTACK-4088


Repository: cloudstack-git


Description
-------

fullSync will check if the vm is following CS naming and will stop the vms which are not belongs to CS and having the same name with CS vms.
but in deltaSync it will stop all vms not belongs to CS.
It is unreasonable to stop or remove a vm that not belongs to CS.


Diffs
-----

  server/src/com/cloud/vm/VirtualMachineManagerImpl.java b33ee49 

Diff: https://reviews.apache.org/r/13268/diff/


Testing
-------

vm which not belongs to CS will not removed or stopped


Thanks,

Hongtu Zang