[GitHub] [lucene-solr] s1monw commented on pull request #1909: LUCENE-9539: Remove caches from SortingCodecReader

[GitBox <gi...@apache.org>]

s1monw commented on pull request #1909:
URL: https://github.com/apache/lucene-solr/pull/1909#issuecomment-697184182


   > I think our current DV format pulls doc values for a single field several times when flushing/merging, e.g. first to figure out whether the field is single-valued and how many bits per value are needed, and a second time to actually write data. Should we at least cache the last DVs that got pulled so that the second time you pull them, we don't re-do a lot of work?
   
   that's correct. some of them are pulled like 5 times. I added a very simple cache and assertions that makes sure we can reuse the same instance if it's pulled more than once.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org