You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/09/26 00:14:27 UTC
Review Request 38777: Avoid closing '-1' file descriptors in
Subprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38777/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
close here can be called with some fds equal to -1
Diffs
-----
3rdparty/libprocess/src/subprocess.cpp 5ff784878e636c6a83db2633c2c16a4ed93d7879
Diff: https://reviews.apache.org/r/38777/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 38777: Avoid closing '-1' file descriptors in
Subprocess.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38777/#review100697
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 25, 2015, 10:14 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38777/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 10:14 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> close here can be called with some fds equal to -1
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp 5ff784878e636c6a83db2633c2c16a4ed93d7879
>
> Diff: https://reviews.apache.org/r/38777/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>