You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Artemy Tregubenko (JIRA)" <ji...@apache.org> on 2008/02/19 17:08:43 UTC
[jira] Created: (SHINDIG-83) gadgets.util.hasFeature is currently
inversed
gadgets.util.hasFeature is currently inversed
---------------------------------------------
Key: SHINDIG-83
URL: https://issues.apache.org/jira/browse/SHINDIG-83
Project: Shindig
Issue Type: Bug
Components: Features
Reporter: Artemy Tregubenko
Assignee: Kevin Brown
At the moment hasFeature reports true for every unknown feature because of typo (?):
hasFeature : function (feature) {
return typeof features[feature] === "undefined";
},
Well, actually it does for any feature name, as `features` here should be initialized via gadgets.util.init(features), which is never called, because gadgets.config.init is called instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-83) gadgets.util.hasFeature is currently
not implemented.
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573366#action_12573366 ]
Kevin Brown commented on SHINDIG-83:
------------------------------------
Yes -- I was talking to Zhen about doing the same thing, so you might want to check with him to see if he was already working on it.
That won't quite solve this particular issue, though, because we also need to pass the feature params for the gadget. hasFeature is supposed to be the union of features that the container / rendering server supports and what the gadget requires.
> gadgets.util.hasFeature is currently not implemented.
> -----------------------------------------------------
>
> Key: SHINDIG-83
> URL: https://issues.apache.org/jira/browse/SHINDIG-83
> Project: Shindig
> Issue Type: Bug
> Components: Features, Gadgets Server - Java
> Reporter: Artemy Tregubenko
> Assignee: Kevin Brown
> Attachments: patch
>
>
> At the moment hasFeature reports true for every unknown feature because of typo (?):
> hasFeature : function (feature) {
> return typeof features[feature] === "undefined";
> },
> Well, actually it does for any feature name, as `features` here should be initialized via gadgets.util.init(features), which is never called, because gadgets.config.init is called instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-83) gadgets.util.hasFeature is currently
not implemented.
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown updated SHINDIG-83:
-------------------------------
Component/s: Gadgets Server - Java
Remaining Estimate: (was: 0.08h)
Original Estimate: (was: 0.08h)
Summary: gadgets.util.hasFeature is currently not implemented. (was: gadgets.util.hasFeature is currently inversed)
> gadgets.util.hasFeature is currently not implemented.
> -----------------------------------------------------
>
> Key: SHINDIG-83
> URL: https://issues.apache.org/jira/browse/SHINDIG-83
> Project: Shindig
> Issue Type: Bug
> Components: Features, Gadgets Server - Java
> Reporter: Artemy Tregubenko
> Assignee: Kevin Brown
> Attachments: patch
>
>
> At the moment hasFeature reports true for every unknown feature because of typo (?):
> hasFeature : function (feature) {
> return typeof features[feature] === "undefined";
> },
> Well, actually it does for any feature name, as `features` here should be initialized via gadgets.util.init(features), which is never called, because gadgets.config.init is called instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-83) gadgets.util.hasFeature is currently
not implemented.
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573328#action_12573328 ]
Paul Lindner commented on SHINDIG-83:
-------------------------------------
Kevin,
Could we move the list of supported features into the syndicator configuration?
This way different syndicators could pick and choose which features they would like to support.
If you concur I can write up a patch for this.
> gadgets.util.hasFeature is currently not implemented.
> -----------------------------------------------------
>
> Key: SHINDIG-83
> URL: https://issues.apache.org/jira/browse/SHINDIG-83
> Project: Shindig
> Issue Type: Bug
> Components: Features, Gadgets Server - Java
> Reporter: Artemy Tregubenko
> Assignee: Kevin Brown
> Attachments: patch
>
>
> At the moment hasFeature reports true for every unknown feature because of typo (?):
> hasFeature : function (feature) {
> return typeof features[feature] === "undefined";
> },
> Well, actually it does for any feature name, as `features` here should be initialized via gadgets.util.init(features), which is never called, because gadgets.config.init is called instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-83) gadgets.util.hasFeature is currently
not implemented.
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown closed SHINDIG-83.
------------------------------
Resolution: Fixed
Original issue fixed -- possibly open up a new issue if we deem the other issue important enough to implement.
> gadgets.util.hasFeature is currently not implemented.
> -----------------------------------------------------
>
> Key: SHINDIG-83
> URL: https://issues.apache.org/jira/browse/SHINDIG-83
> Project: Shindig
> Issue Type: Bug
> Components: Features, Gadgets Server - Java
> Reporter: Artemy Tregubenko
> Assignee: Kevin Brown
> Attachments: patch
>
>
> At the moment hasFeature reports true for every unknown feature because of typo (?):
> hasFeature : function (feature) {
> return typeof features[feature] === "undefined";
> },
> Well, actually it does for any feature name, as `features` here should be initialized via gadgets.util.init(features), which is never called, because gadgets.config.init is called instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-83) gadgets.util.hasFeature is currently
inversed
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Artemy Tregubenko updated SHINDIG-83:
-------------------------------------
Attachment: patch
> gadgets.util.hasFeature is currently inversed
> ---------------------------------------------
>
> Key: SHINDIG-83
> URL: https://issues.apache.org/jira/browse/SHINDIG-83
> Project: Shindig
> Issue Type: Bug
> Components: Features
> Reporter: Artemy Tregubenko
> Assignee: Kevin Brown
> Attachments: patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> At the moment hasFeature reports true for every unknown feature because of typo (?):
> hasFeature : function (feature) {
> return typeof features[feature] === "undefined";
> },
> Well, actually it does for any feature name, as `features` here should be initialized via gadgets.util.init(features), which is never called, because gadgets.config.init is called instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-83) gadgets.util.hasFeature is currently
inversed
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570344#action_12570344 ]
Kevin Brown commented on SHINDIG-83:
------------------------------------
hasFeature (and getFeatureParams) are not actually implemented at present -- it requires server side code as well to correctly pass the feature params down.
> gadgets.util.hasFeature is currently inversed
> ---------------------------------------------
>
> Key: SHINDIG-83
> URL: https://issues.apache.org/jira/browse/SHINDIG-83
> Project: Shindig
> Issue Type: Bug
> Components: Features, Gadgets Server - Java
> Reporter: Artemy Tregubenko
> Assignee: Kevin Brown
> Attachments: patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> At the moment hasFeature reports true for every unknown feature because of typo (?):
> hasFeature : function (feature) {
> return typeof features[feature] === "undefined";
> },
> Well, actually it does for any feature name, as `features` here should be initialized via gadgets.util.init(features), which is never called, because gadgets.config.init is called instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.