You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/07 06:28:42 UTC
[GitHub] [airflow] a-poptsov opened a new issue #10777: KubernetesPodOperator Secret doesn't use key property when attaching to pod as volume
a-poptsov opened a new issue #10777:
URL: https://github.com/apache/airflow/issues/10777
For the case when secret key is specified system should handle this key during attaching secret to pod as volume.
Expected result is:
> only specified key should be attached from full secret. it should be mounted as a file to the path == volume_mount https://kubernetes.io/docs/concepts/configuration/secret/#projection-of-secret-keys-to-specific-paths
Current result:
> all keys are attached if key property is presented in secret https://github.com/apache/airflow/blob/v1-10-stable/airflow/kubernetes/secret.py#L107
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] a-poptsov commented on issue #10777: KubernetesPodOperator Secret doesn't use key property when attaching to pod as volume
Posted by GitBox <gi...@apache.org>.
a-poptsov commented on issue #10777:
URL: https://github.com/apache/airflow/issues/10777#issuecomment-688070258
According my limited understanding we should specify items=[self.key] in the https://github.com/apache/airflow/blob/v1-10-stable/airflow/kubernetes/secret.py#L99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #10777: KubernetesPodOperator Secret doesn't use key property when attaching to pod as volume
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #10777:
URL: https://github.com/apache/airflow/issues/10777#issuecomment-688066815
Thanks for opening your first issue here! Be sure to follow the issue template!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] a-poptsov commented on issue #10777: KubernetesPodOperator Secret doesn't use key property when attaching to pod as volume
Posted by GitBox <gi...@apache.org>.
a-poptsov commented on issue #10777:
URL: https://github.com/apache/airflow/issues/10777#issuecomment-706649463
@dimberman Sorry for late response. Thanks for a great job with adding items field. But I think it is partial fix. Secret contains all required information already even without using items directly. For example I can specify `
`Secret("volume", "/etc/ca.pem", "secret_name", "secret_key")`` I am expecting that only selected key will be mounted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman closed issue #10777: KubernetesPodOperator Secret doesn't use key property when attaching to pod as volume
Posted by GitBox <gi...@apache.org>.
dimberman closed issue #10777:
URL: https://github.com/apache/airflow/issues/10777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on issue #10777: KubernetesPodOperator Secret doesn't use key property when attaching to pod as volume
Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #10777:
URL: https://github.com/apache/airflow/issues/10777#issuecomment-705965379
@a-poptsov would this fix this issue? https://github.com/apache/airflow/pull/11369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on issue #10777: KubernetesPodOperator Secret doesn't use key property when attaching to pod as volume
Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #10777:
URL: https://github.com/apache/airflow/issues/10777#issuecomment-705965379
@a-poptsov would this fix this issue? https://github.com/apache/airflow/pull/11369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] a-poptsov commented on issue #10777: KubernetesPodOperator Secret doesn't use key property when attaching to pod as volume
Posted by GitBox <gi...@apache.org>.
a-poptsov commented on issue #10777:
URL: https://github.com/apache/airflow/issues/10777#issuecomment-706649877
I suggest to add items by default in the case that was specified in prev. comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org