[jira] [Commented] (STORM-1220) Avoid double copying in the Kafka spout

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014428#comment-15014428 ] 

ASF GitHub Bot commented on STORM-1220:
---------------------------------------

GitHub user haohui opened a pull request:

    https://github.com/apache/storm/pull/894

    STORM-1220. Avoid double copying in the Kafka spout.

    Currently the Kafka spout performs an extra copy for all payloads in Kafka when integrating with Storm. This PR proposes to avoid the extra copy to improve performance.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/haohui/storm STORM-1220

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/894.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #894
    
----
commit 0850c7a3059bec664524d842ea98aecc5e19889f
Author: Haohui Mai <wh...@apache.org>
Date:   2015-11-19T21:32:20Z

    STORM-1220. Avoid double copying in the Kafka spout.

----


> Avoid double copying in the Kafka spout
> ---------------------------------------
>
>                 Key: STORM-1220
>                 URL: https://issues.apache.org/jira/browse/STORM-1220
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>
> Currently the kafka spout takes a {{ByteBuffer}} from Kafka. However, the serialization scheme takes a {{byte[]}} array as input. Therefore the current implementation copies the {{ByteBuffer}} to a new {{byte[]}} array in order to hook everything together.
> This jira proposes to changes the interfaces of serialization scheme to avoid copying the data twice in the spout.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)