[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #793: MINIFICPP-1237 - Event driven scheduler shouldn't schedule processors…

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #793:
URL: https://github.com/apache/nifi-minifi-cpp/pull/793#discussion_r431023940



##########
File path: libminifi/src/EventDrivenSchedulingAgent.cpp
##########
@@ -29,6 +29,13 @@ namespace apache {
 namespace nifi {
 namespace minifi {
 
+void EventDrivenSchedulingAgent::schedule(std::shared_ptr<core::Processor> processor) {
+  if (!processor->hasIncomingConnections()) {
+    throw Exception(PROCESS_SCHEDULE_EXCEPTION, "EventDrivenSchedulingAgent cannot schedule processor without incoming connection!");

Review comment:
       Exactly that happens where the exception is handled (ProcessGroup.cpp):
   
   ```
       catch (const std::exception &e) {
         logger_->log_error("Failed to start processor %s (%s): %s", processor->getUUIDStr(), processor->getName(), e.what());
         failed_processors.insert(processor);
       }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org