You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by mgoulish <gi...@git.apache.org> on 2018/09/20 10:22:57 UTC
[GitHub] qpid-dispatch pull request #380: DISPATCH-1096 - use default priority if und...
GitHub user mgoulish opened a pull request:
https://github.com/apache/qpid-dispatch/pull/380
DISPATCH-1096 - use default priority if undefined
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgoulish/qpid-dispatch priority-5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/380.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #380
----
commit 18325aa66a93e2aded1c2e2efe8bccf1964460c1
Author: Michael Goulish <mg...@...>
Date: 2018-09-20T10:15:44Z
DISPATCH-1096 - use default priority if undefined
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #380: DISPATCH-1096 - use default priority if undefined
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/380
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/380?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@16f378e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/380?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #380 +/- ##
=========================================
Coverage ? 84.48%
=========================================
Files ? 72
Lines ? 16175
Branches ? 0
=========================================
Hits ? 13666
Misses ? 2509
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/380?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/380/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `93.45% <0%> (ø)` | |
| [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/380/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `88.98% <100%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/380?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/380?src=pr&el=footer). Last update [16f378e...18325aa](https://codecov.io/gh/apache/qpid-dispatch/pull/380?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #380: DISPATCH-1096 - use default priority if und...
Posted by mgoulish <gi...@git.apache.org>.
Github user mgoulish closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/380
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #380: DISPATCH-1096 - use default priority if undefined
Posted by mgoulish <gi...@git.apache.org>.
Github user mgoulish commented on the issue:
https://github.com/apache/qpid-dispatch/pull/380
This is superseded by Ted's commit e3e201652ca167e9a6cd3d12ff3106165f3bb89a "DISPATCH-1132 - Cleaned up message header parsing"
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #380: DISPATCH-1096 - use default priority if und...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/380#discussion_r219184701
--- Diff: src/iterator.c ---
@@ -768,10 +768,11 @@ char* qd_iterator_strncpy(qd_iterator_t *iter, char* buffer, int n)
}
-uint8_t qd_iterator_uint8(qd_iterator_t *iter ) {
+// Return invalid value if iterator is empty.
+int32_t qd_iterator_uint8(qd_iterator_t *iter ) {
qd_iterator_reset(iter);
if (qd_iterator_end(iter))
- return 0;
+ return -1;
--- End diff --
I don't think this is sufficient to cover all the possible cases. This function is a little out of place in the iterator module. The iterator is not intended to do decoding. There are other functions in place to parse values out of iterators (see parse.h).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org