You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Ben Gidley <be...@gidley.co.uk> on 2009/08/06 09:05:32 UTC
Re: TAP5-769 and interface changes
Hi,
Is there any chance of a commiter reviewing these patches -
https://issues.apache.org/jira/browse/TAP5-769? I am happy to modify them if
you feel they need adjustment!
<https://issues.apache.org/jira/browse/TAP5-769>
Ben Gidley
www.gidley.co.uk
ben@gidley.co.uk
On Fri, Jul 17, 2009 at 12:45 PM, Ben Gidley <be...@gidley.co.uk> wrote:
> I have posted a patch for https://issues.apache.org/jira/browse/TAP5-769 that
> resolves the issue. It allows javascript to be grouped into combined files
> thus allowing you to share common javascript between pages.
> An obvious enhancement would be to expose this to RenderSupport (at the
> moment I have only made 'internal' changes) - however I was unsure of how
> the interface should be changed. Following the thread recently -
> RenderSupport is mostly an interface you would expect people to use not
> implement, but it is not impossible someone has implemented it or wrapped
> it.
>
> So presuming a RenderSupport.addGroupedScriptLink(String group, String...
> scriptURLs) was desirable should I create a RenderSupport2 or just add it to
> RenderSupport?
>
> As an aside what is the preferred way of telling commiters about patches -
> do you want an email to this list as well as adding it to JIRA?
>
> Ben Gidley
>
> www.gidley.co.uk
> ben@gidley.co.uk
>
Re: TAP5-769 and interface changes
Posted by Robert Zeigler <ro...@scazdl.org>.
I'll take a look at the patches this weekend.
Cheers,
Robert
On Aug 6, 2009, at 8/62:05 AM , Ben Gidley wrote:
> Hi,
> Is there any chance of a commiter reviewing these patches -
> https://issues.apache.org/jira/browse/TAP5-769? I am happy to modify
> them if
> you feel they need adjustment!
>
> <https://issues.apache.org/jira/browse/TAP5-769>
> Ben Gidley
>
> www.gidley.co.uk
> ben@gidley.co.uk
>
>
> On Fri, Jul 17, 2009 at 12:45 PM, Ben Gidley <be...@gidley.co.uk> wrote:
>
>> I have posted a patch for https://issues.apache.org/jira/browse/TAP5-769
>> that
>> resolves the issue. It allows javascript to be grouped into
>> combined files
>> thus allowing you to share common javascript between pages.
>> An obvious enhancement would be to expose this to RenderSupport (at
>> the
>> moment I have only made 'internal' changes) - however I was unsure
>> of how
>> the interface should be changed. Following the thread recently -
>> RenderSupport is mostly an interface you would expect people to use
>> not
>> implement, but it is not impossible someone has implemented it or
>> wrapped
>> it.
>>
>> So presuming a RenderSupport.addGroupedScriptLink(String group,
>> String...
>> scriptURLs) was desirable should I create a RenderSupport2 or just
>> add it to
>> RenderSupport?
>>
>> As an aside what is the preferred way of telling commiters about
>> patches -
>> do you want an email to this list as well as adding it to JIRA?
>>
>> Ben Gidley
>>
>> www.gidley.co.uk
>> ben@gidley.co.uk
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org