You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Jason van Zyl <jv...@apache.org> on 2001/07/17 10:49:58 UTC

Re: cvs commit: jakarta-turbine/src/java/org/apache/turbine/util/parser BaseValueParser.java ValueParser.java

On 7/17/01 3:37 AM, "jon@apache.org" <jo...@apache.org> wrote:

> jon         01/07/17 00:37:41
> 
> Modified:    src/adapter/org/apache/turbine/util/velocity
>                       VelocityHtmlEmail.java
>              src/java/org/apache/turbine TemplateContext.java
>              src/java/org/apache/turbine/modules ContextAdapter.java
>              src/java/org/apache/turbine/modules/actions
>                       TemplateAction.java TemplateSecureAction.java
>              src/java/org/apache/turbine/pipeline ClassicPipeline.java
>              src/java/org/apache/turbine/services/db
>                       TurbineDatabaseService.java
>              src/java/org/apache/turbine/services/pull
>                       ApplicationTool.java PullService.java
>                       TurbinePull.java TurbinePullService.java
>              src/java/org/apache/turbine/services/pull/util
>                       UIManager.java
>              src/java/org/apache/turbine/services/template
>                       BaseTemplateEngineService.java
>                       DefaultTemplateContext.java
>                       TemplateEngineService.java TemplateService.java
>                       TurbineTemplate.java TurbineTemplateService.java
>              src/java/org/apache/turbine/services/velocity
>                       ContextAdapter.java TurbineVelocity.java
>                       TurbineVelocityService.java VelocityService.java
>              src/java/org/apache/turbine/services/xmlrpc
>                       TurbineXmlRpc.java TurbineXmlRpcService.java
>                       XmlRpcService.java
>              src/java/org/apache/turbine/services/xmlrpc/util
>                       FileTransfer.java
>              src/java/org/apache/turbine/torque TorqueCreateDatabase.java
>                       TorqueDataSQLTask.java TorqueJDBCTransformTask.java
>                       TorqueObjectModelTask.java TorqueSQLTask.java
>              src/java/org/apache/turbine/torque/engine/database/model
>                       Column.java Index.java Table.java TypeMap.java
>                       Unique.java
>              src/java/org/apache/turbine/torque/engine/database/transform
>                       XmlToAppData.java XmlToData.java
>              src/java/org/apache/turbine/util ContentURI.java
>                       DynamicURI.java
>              src/java/org/apache/turbine/util/parser BaseValueParser.java
>                       ValueParser.java
> Removed:     src/java/org/apache/turbine/services/template
>                       TemplateContext.java
> Log:
> remove o.a.t.s.template.TemplateContext because it is causing confusion
> with o.a.t.TemplateContext

that's not right. you just coupled the template services to turbine
again. turbine code references the turbine namespace, and service code
references the service namespace. the TemplateContext in the template
service is a general context for the template services and there are
adapters in each of the template service engines to make this general
TemplateContext work in the template engine.

The org.apache.turbine.TemplateContext is a different beast though it
looks very similar. This is the class used in turbine client code,
and there is another adapter to turn this class used in turbine code
to the general TemplateContext used in the template service.

This allows the decoupling of the template service from Turbine. There
is no reason that the template service can't be used outside the context
of Turbine. And even if most people don't do that the decoupling is
better designer and will allow greater flexibility in the future and
will allow the services to compile in a separate tree. They definitely
won't with the change you just made.
 
> fix jason's email address with a global find/replace in the src directory
> 

-- 

jvz.

Jason van Zyl

http://tambora.zenplex.org
http://jakarta.apache.org/turbine
http://jakarta.apache.org/velocity
http://jakarta.apache.org/alexandria
http://jakarta.apache.org/commons



---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org