You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2009/06/10 00:16:53 UTC

DO NOT REPLY [Bug 47340] New: uldap_cache_comparedn() called without a lock

https://issues.apache.org/bugzilla/show_bug.cgi?id=47340

           Summary: uldap_cache_comparedn() called without a lock
           Product: Apache httpd-2
           Version: 2.2.11
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: All
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: tammy000@gmail.com


Per the block comment before the body of function uldap_cache_comparedn(), a
lock must be held already:

/* ...
   The lock for the ldap cache should already be acquired */
static int uldap_cache_comparedn() ...)

But when it is called from authz_ldap_check_user_access(), no lock is held
before calling uldap_cache_comparedn(). It is a bug, or the comment is
outdated?


Detected by an automatic tool iComment.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org

DO NOT REPLY [Bug 47340] uldap_cache_comparedn() called without a lock

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47340





--- Comment #1 from Dan Poirier <po...@pobox.com>  2009-06-10 06:01:48 PST ---
There only seems to be one cache lock, and this function acquires and releases
it internally several times, so it certainly seems unnecessary for the lock to
already be held before calling it.

I was hoping to find a revision in which this internal locking was added
without removing that comment, but it appears to have been this way since
before the file was added to subversion
(http://svn.apache.org/viewvc?view=rev&revision=91504).

Still, I think the comment is wrong.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org

DO NOT REPLY [Bug 47340] uldap_cache_comparedn() called without a lock

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47340


Tammy <ta...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tammy000@gmail.com




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org