You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2014/09/26 08:40:57 UTC
Review Request 26074: SENTRY-472: Hive binding should validate URI
privileges on permenant function resource URI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26074/
-----------------------------------------------------------
Review request for sentry and Sravya Tirukkovalur.
Bugs: SENTRY-472
https://issues.apache.org/jira/browse/SENTRY-472
Repository: sentry
Description
-------
Hive binding should validate URI privileges on permenant function resource URI. The patch includes the output URI check so that if the UDF as a resource URI it will be verified.
The patch depends on HIVE-8266 which enables Hive compiler to capture the URI information from create function statement.
Diffs
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java f872ea2
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java 2f97e30
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java f1f64e6
Diff: https://reviews.apache.org/r/26074/diff/
Testing
-------
Added permenant function test cases. The case which needs HIVE-8266 patch is currently commented out.
Thanks,
Prasad Mujumdar
Re: Review Request 26074: SENTRY-472: Hive binding should validate URI
privileges on permenant function resource URI
Posted by Prasad Mujumdar <pr...@cloudera.com>.
> On Sept. 26, 2014, 8:56 p.m., Sravya Tirukkovalur wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java, lines 101-109
> > <https://reviews.apache.org/r/26074/diff/2/?file=706167#file706167line101>
> >
> > Statements repeated 2 times?
>
> Prasad Mujumdar wrote:
> Updated.
Updated patch attached to the ticket
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26074/#review54713
-----------------------------------------------------------
On Sept. 26, 2014, 5:29 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26074/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 5:29 p.m.)
>
>
> Review request for sentry and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-472
> https://issues.apache.org/jira/browse/SENTRY-472
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Hive binding should validate URI privileges on permenant function resource URI. The patch includes the output URI check so that if the UDF as a resource URI it will be verified.
> The patch depends on HIVE-8266 which enables Hive compiler to capture the URI information from create function statement.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java f872ea2
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java 2f97e30
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java f1f64e6
>
> Diff: https://reviews.apache.org/r/26074/diff/
>
>
> Testing
> -------
>
> Added permenant function test cases. The case which needs HIVE-8266 patch is currently commented out.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 26074: SENTRY-472: Hive binding should validate URI
privileges on permenant function resource URI
Posted by Prasad Mujumdar <pr...@cloudera.com>.
> On Sept. 26, 2014, 8:56 p.m., Sravya Tirukkovalur wrote:
> > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java, lines 101-109
> > <https://reviews.apache.org/r/26074/diff/2/?file=706167#file706167line101>
> >
> > Statements repeated 2 times?
Updated.
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26074/#review54713
-----------------------------------------------------------
On Sept. 26, 2014, 5:29 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26074/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 5:29 p.m.)
>
>
> Review request for sentry and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-472
> https://issues.apache.org/jira/browse/SENTRY-472
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Hive binding should validate URI privileges on permenant function resource URI. The patch includes the output URI check so that if the UDF as a resource URI it will be verified.
> The patch depends on HIVE-8266 which enables Hive compiler to capture the URI information from create function statement.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java f872ea2
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java 2f97e30
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java f1f64e6
>
> Diff: https://reviews.apache.org/r/26074/diff/
>
>
> Testing
> -------
>
> Added permenant function test cases. The case which needs HIVE-8266 patch is currently commented out.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 26074: SENTRY-472: Hive binding should validate URI
privileges on permenant function resource URI
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26074/#review54713
-----------------------------------------------------------
Ship it!
Minor comment below.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java
<https://reviews.apache.org/r/26074/#comment95018>
Statements repeated 2 times?
- Sravya Tirukkovalur
On Sept. 26, 2014, 5:29 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26074/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 5:29 p.m.)
>
>
> Review request for sentry and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-472
> https://issues.apache.org/jira/browse/SENTRY-472
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Hive binding should validate URI privileges on permenant function resource URI. The patch includes the output URI check so that if the UDF as a resource URI it will be verified.
> The patch depends on HIVE-8266 which enables Hive compiler to capture the URI information from create function statement.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java f872ea2
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java 2f97e30
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java f1f64e6
>
> Diff: https://reviews.apache.org/r/26074/diff/
>
>
> Testing
> -------
>
> Added permenant function test cases. The case which needs HIVE-8266 patch is currently commented out.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>
Re: Review Request 26074: SENTRY-472: Hive binding should validate URI
privileges on permenant function resource URI
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26074/
-----------------------------------------------------------
(Updated Sept. 26, 2014, 5:29 p.m.)
Review request for sentry and Sravya Tirukkovalur.
Changes
-------
Added comment on the disabled testcase
Bugs: SENTRY-472
https://issues.apache.org/jira/browse/SENTRY-472
Repository: sentry
Description
-------
Hive binding should validate URI privileges on permenant function resource URI. The patch includes the output URI check so that if the UDF as a resource URI it will be verified.
The patch depends on HIVE-8266 which enables Hive compiler to capture the URI information from create function statement.
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java f872ea2
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java 2f97e30
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java f1f64e6
Diff: https://reviews.apache.org/r/26074/diff/
Testing
-------
Added permenant function test cases. The case which needs HIVE-8266 patch is currently commented out.
Thanks,
Prasad Mujumdar