[jira] Issue Comment Edited: (WICKET-2235) Image tags using full paths are broken when wrapped in an a tag that uses wicket:link

["Jeremy Thomerson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703503#action_12703503 ] 

Jeremy Thomerson edited comment on WICKET-2235 at 4/27/09 11:12 PM:
--------------------------------------------------------------------

Not sure, but it may be related to a patch I submitted (someone else committed - before I was a committer) around that timeframe for the following:
WICKET-1513

I will try to look soon.

NEVER MIND - I have looked at that patch and it did not change the behavior for IMG tags at all - it just added input and embed tags to the AutoLinkResolver.


      was (Author: jthomerson):
    Not sure, but it may be related to a patch I submitted (someone else committed - before I was a committer) around that timeframe for the following:
https://issues.apache.org/jira/browse/WICKET-1513

I will try to look soon.
  
> Image tags using full paths are broken when wrapped in an a tag that uses wicket:link
> -------------------------------------------------------------------------------------
>
>                 Key: WICKET-2235
>                 URL: https://issues.apache.org/jira/browse/WICKET-2235
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4-RC1, 1.4-RC2
>         Environment: Safari  on OS X, probably others
>            Reporter: Mike Comb
>            Assignee: Igor Vaynberg
>
> HTML that looks like this:
> <wicket:link><a href="SomePage.html"><img src="/some/full/path/image.gif" /></a></wicket:link>
> Will get converted to this:
> <wicket:link><a href="../SomePage"><img onclick="window.location.href='/some/full/path/image.gif';return false;" src="/some/full/path/image.gif"/></a></wicket:link>
> The onclick that gets added to the image is unnecessary and results in the browser directing to the image rather than the intended target page when the image is clicked on.  This behavior is still present in trunk as of 4/22/09.  A temporary workaround is to comment out the offending line in ExternalLink.java that is adding the onclick event.  It's unclear to me what the purpose of that event is.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.