You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/08/16 01:23:51 UTC
[GitHub] [airflow] uranusjr commented on a diff in pull request #33403: Respect "soft_fail" for core async sensors
uranusjr commented on code in PR #33403:
URL: https://github.com/apache/airflow/pull/33403#discussion_r1295290027
##########
airflow/triggers/temporal.py:
##########
@@ -34,18 +35,29 @@ class DateTimeTrigger(BaseTrigger):
The provided datetime MUST be in UTC.
"""
- def __init__(self, moment: datetime.datetime):
+ def __init__(self, moment: datetime.datetime, soft_fail: bool = False):
Review Comment:
```suggestion
def __init__(self, moment: datetime.datetime, *, soft_fail: bool = False) -> None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org