You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/13 22:54:04 UTC
[GitHub] [kafka] xvrl opened a new pull request #9429: KAFKA-10572 mirror-maker config changes for KIP-629
xvrl opened a new pull request #9429:
URL: https://github.com/apache/kafka/pull/9429
This change implements the KIP-629 changes for mirror maker configuration with backwards compatibility.
cc @rhauch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rhauch merged pull request #9429: KAFKA-10572 mirror-maker config changes for KIP-629
Posted by GitBox <gi...@apache.org>.
rhauch merged pull request #9429:
URL: https://github.com/apache/kafka/pull/9429
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rhauch commented on a change in pull request #9429: KAFKA-10572 mirror-maker config changes for KIP-629
Posted by GitBox <gi...@apache.org>.
rhauch commented on a change in pull request #9429:
URL: https://github.com/apache/kafka/pull/9429#discussion_r507840010
##########
File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java
##########
@@ -436,29 +444,47 @@ Duration syncGroupOffsetsInterval() {
ConfigDef.Importance.HIGH,
TOPICS_DOC)
.define(
- TOPICS_BLACKLIST,
+ TOPICS_EXCLUDE,
+ ConfigDef.Type.LIST,
Review comment:
```suggestion
ConfigDef.Type.LIST,
```
##########
File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java
##########
@@ -436,29 +444,47 @@ Duration syncGroupOffsetsInterval() {
ConfigDef.Importance.HIGH,
TOPICS_DOC)
.define(
- TOPICS_BLACKLIST,
+ TOPICS_EXCLUDE,
+ ConfigDef.Type.LIST,
+ TOPICS_EXCLUDE_DEFAULT,
+ ConfigDef.Importance.HIGH,
Review comment:
```suggestion
ConfigDef.Importance.HIGH,
```
##########
File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java
##########
@@ -436,29 +444,47 @@ Duration syncGroupOffsetsInterval() {
ConfigDef.Importance.HIGH,
TOPICS_DOC)
.define(
- TOPICS_BLACKLIST,
+ TOPICS_EXCLUDE,
+ ConfigDef.Type.LIST,
+ TOPICS_EXCLUDE_DEFAULT,
+ ConfigDef.Importance.HIGH,
+ TOPICS_EXCLUDE_DOC)
+ .define(
+ TOPICS_EXCLUDE_ALIAS,
ConfigDef.Type.LIST,
- TOPICS_BLACKLIST_DEFAULT,
+ null,
ConfigDef.Importance.HIGH,
- TOPICS_BLACKLIST_DOC)
+ "Deprecated. Use " + TOPICS_EXCLUDE + " instead.")
.define(
GROUPS,
ConfigDef.Type.LIST,
GROUPS_DEFAULT,
ConfigDef.Importance.HIGH,
GROUPS_DOC)
.define(
- GROUPS_BLACKLIST,
+ GROUPS_EXCLUDE,
+ ConfigDef.Type.LIST,
Review comment:
```suggestion
ConfigDef.Type.LIST,
```
##########
File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java
##########
@@ -436,29 +444,47 @@ Duration syncGroupOffsetsInterval() {
ConfigDef.Importance.HIGH,
TOPICS_DOC)
.define(
- TOPICS_BLACKLIST,
+ TOPICS_EXCLUDE,
+ ConfigDef.Type.LIST,
+ TOPICS_EXCLUDE_DEFAULT,
+ ConfigDef.Importance.HIGH,
+ TOPICS_EXCLUDE_DOC)
+ .define(
+ TOPICS_EXCLUDE_ALIAS,
ConfigDef.Type.LIST,
- TOPICS_BLACKLIST_DEFAULT,
+ null,
ConfigDef.Importance.HIGH,
- TOPICS_BLACKLIST_DOC)
+ "Deprecated. Use " + TOPICS_EXCLUDE + " instead.")
.define(
GROUPS,
ConfigDef.Type.LIST,
GROUPS_DEFAULT,
ConfigDef.Importance.HIGH,
GROUPS_DOC)
.define(
- GROUPS_BLACKLIST,
+ GROUPS_EXCLUDE,
+ ConfigDef.Type.LIST,
+ GROUPS_EXCLUDE_DEFAULT,
+ ConfigDef.Importance.HIGH,
+ GROUPS_EXCLUDE_DOC)
+ .define(
+ GROUPS_EXCLUDE_ALIAS,
ConfigDef.Type.LIST,
- GROUPS_BLACKLIST_DEFAULT,
+ null,
ConfigDef.Importance.HIGH,
- GROUPS_BLACKLIST_DOC)
+ "Deprecated. Use " + GROUPS_EXCLUDE + " instead.")
+ .define(
+ CONFIG_PROPERTIES_EXCLUDE,
+ ConfigDef.Type.LIST,
Review comment:
```suggestion
ConfigDef.Type.LIST,
```
##########
File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java
##########
@@ -436,29 +444,47 @@ Duration syncGroupOffsetsInterval() {
ConfigDef.Importance.HIGH,
TOPICS_DOC)
.define(
- TOPICS_BLACKLIST,
+ TOPICS_EXCLUDE,
+ ConfigDef.Type.LIST,
+ TOPICS_EXCLUDE_DEFAULT,
+ ConfigDef.Importance.HIGH,
+ TOPICS_EXCLUDE_DOC)
+ .define(
+ TOPICS_EXCLUDE_ALIAS,
ConfigDef.Type.LIST,
- TOPICS_BLACKLIST_DEFAULT,
+ null,
ConfigDef.Importance.HIGH,
- TOPICS_BLACKLIST_DOC)
+ "Deprecated. Use " + TOPICS_EXCLUDE + " instead.")
.define(
GROUPS,
ConfigDef.Type.LIST,
GROUPS_DEFAULT,
ConfigDef.Importance.HIGH,
GROUPS_DOC)
.define(
- GROUPS_BLACKLIST,
+ GROUPS_EXCLUDE,
+ ConfigDef.Type.LIST,
+ GROUPS_EXCLUDE_DEFAULT,
+ ConfigDef.Importance.HIGH,
+ GROUPS_EXCLUDE_DOC)
+ .define(
+ GROUPS_EXCLUDE_ALIAS,
ConfigDef.Type.LIST,
- GROUPS_BLACKLIST_DEFAULT,
+ null,
ConfigDef.Importance.HIGH,
- GROUPS_BLACKLIST_DOC)
+ "Deprecated. Use " + GROUPS_EXCLUDE + " instead.")
+ .define(
+ CONFIG_PROPERTIES_EXCLUDE,
+ ConfigDef.Type.LIST,
+ CONFIG_PROPERTIES_EXCLUDE_DEFAULT,
+ ConfigDef.Importance.HIGH,
Review comment:
```suggestion
ConfigDef.Importance.HIGH,
```
##########
File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java
##########
@@ -436,29 +444,47 @@ Duration syncGroupOffsetsInterval() {
ConfigDef.Importance.HIGH,
TOPICS_DOC)
.define(
- TOPICS_BLACKLIST,
+ TOPICS_EXCLUDE,
+ ConfigDef.Type.LIST,
+ TOPICS_EXCLUDE_DEFAULT,
+ ConfigDef.Importance.HIGH,
+ TOPICS_EXCLUDE_DOC)
+ .define(
+ TOPICS_EXCLUDE_ALIAS,
ConfigDef.Type.LIST,
- TOPICS_BLACKLIST_DEFAULT,
+ null,
ConfigDef.Importance.HIGH,
- TOPICS_BLACKLIST_DOC)
+ "Deprecated. Use " + TOPICS_EXCLUDE + " instead.")
.define(
GROUPS,
ConfigDef.Type.LIST,
GROUPS_DEFAULT,
ConfigDef.Importance.HIGH,
GROUPS_DOC)
.define(
- GROUPS_BLACKLIST,
+ GROUPS_EXCLUDE,
+ ConfigDef.Type.LIST,
+ GROUPS_EXCLUDE_DEFAULT,
+ ConfigDef.Importance.HIGH,
Review comment:
```suggestion
ConfigDef.Importance.HIGH,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rhauch commented on pull request #9429: KAFKA-10572 mirror-maker config changes for KIP-629
Posted by GitBox <gi...@apache.org>.
rhauch commented on pull request #9429:
URL: https://github.com/apache/kafka/pull/9429#issuecomment-712368155
Rebased to get recent changes to fix the PR builds. Previous build was green prior to my minor indentation changes, but I'll give this build a chance before merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] xvrl commented on pull request #9429: KAFKA-10572 mirror-maker config changes for KIP-629
Posted by GitBox <gi...@apache.org>.
xvrl commented on pull request #9429:
URL: https://github.com/apache/kafka/pull/9429#issuecomment-712340666
thanks for fixing the formatting @rhauch, feel free to merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org