You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/17 04:04:37 UTC

[GitHub] [iotdb] cigarl commented on pull request #5921: [IOTDB-3200] [PartitionInfo] replace bytebuffer with stream

cigarl commented on PR #5921:
URL: https://github.com/apache/iotdb/pull/5921#issuecomment-1128384797

   > Don't forget to clean up redundant snapshot files when takeSnapshot returns false.
   
   Each module that operates on snapshots, such as `partitionInfo` and `clusterSchema`, already deleted temporary files with the finally clause.  There is no need to clean up again in `ConfigRequestExecutor`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org