You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "dipankr (via GitHub)" <gi...@apache.org> on 2023/06/26 13:33:24 UTC
[PR] [ISSUE #4107] made fields final (eventmesh)
dipankr opened a new pull request, #4158:
URL: https://github.com/apache/eventmesh/pull/4158
Fixes #4107 #4106 #4104 #4103.
### Motivation
the changes are pretty straightforward, we can make the fields final
### Modifications
made fields final
also, some cleanup suggested by IDE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4107] made fields final (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4158:
URL: https://github.com/apache/eventmesh/pull/4158#issuecomment-1607823641
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4158](https://app.codecov.io/gh/apache/eventmesh/pull/4158?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (56eb184) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/991cbdae829fcc15698654ca2c737575141f5286?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (991cbda) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 56eb184 differs from pull request most recent head e37e5f8. Consider uploading reports for the commit e37e5f8 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4158 +/- ##
============================================
- Coverage 16.93% 16.92% -0.01%
Complexity 1410 1410
============================================
Files 588 588
Lines 25739 25736 -3
Branches 2387 2373 -14
============================================
- Hits 4358 4355 -3
- Misses 20946 20947 +1
+ Partials 435 434 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/4158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../tcp/client/session/push/DownStreamMsgContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/4158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3B1c2gvRG93blN0cmVhbU1zZ0NvbnRleHQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../protocol/tcp/client/session/push/PushContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/4158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3B1c2gvUHVzaENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...cp/client/session/send/EventMeshTcpSendResult.java](https://app.codecov.io/gh/apache/eventmesh/pull/4158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3NlbmQvRXZlbnRNZXNoVGNwU2VuZFJlc3VsdC5qYXZh) | `0.00% <ø> (ø)` | |
| [...rotocol/tcp/client/session/send/SessionSender.java](https://app.codecov.io/gh/apache/eventmesh/pull/4158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3NlbmQvU2Vzc2lvblNlbmRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ol/tcp/client/session/send/UpStreamMsgContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/4158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3NlbmQvVXBTdHJlYW1Nc2dDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../protocol/tcp/client/task/MessageTransferTask.java](https://app.codecov.io/gh/apache/eventmesh/pull/4158?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC90YXNrL01lc3NhZ2VUcmFuc2ZlclRhc2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4158/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4107] made fields final (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #4158:
URL: https://github.com/apache/eventmesh/pull/4158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org