You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2017/04/27 21:28:17 UTC
[Impala-ASF-CR] IMPALA-5258: Pass CMAKE BUILD TYPE to Impala-lzo
Joe McDonnell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6751
Change subject: IMPALA-5258: Pass CMAKE_BUILD_TYPE to Impala-lzo
......................................................................
IMPALA-5258: Pass CMAKE_BUILD_TYPE to Impala-lzo
Impala-lzo contained a buffer overrun that was only
present when compiled in optimized mode. To avoid this
(IMPALA-5172), Impala-lzo is only compiled in DEBUG mode.
Since the underlying buffer overrun has been resolved,
reenable passing the CMAKE_BUILD_TYPE down to Impala-lzo.
Change-Id: I190d732a8244dd79bc422cc0c563fb09ba2ed561
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/6751/1
--
To view, visit http://gerrit.cloudera.org:8080/6751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I190d732a8244dd79bc422cc0c563fb09ba2ed561
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-5258: Pass CMAKE BUILD TYPE to Impala-lzo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5258: Pass CMAKE_BUILD_TYPE to Impala-lzo
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/555/
--
To view, visit http://gerrit.cloudera.org:8080/6751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d732a8244dd79bc422cc0c563fb09ba2ed561
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5258: Pass CMAKE BUILD TYPE to Impala-lzo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5258: Pass CMAKE_BUILD_TYPE to Impala-lzo
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d732a8244dd79bc422cc0c563fb09ba2ed561
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5258: Pass CMAKE BUILD TYPE to Impala-lzo
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5258: Pass CMAKE_BUILD_TYPE to Impala-lzo
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d732a8244dd79bc422cc0c563fb09ba2ed561
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5258: Pass CMAKE BUILD TYPE to Impala-lzo
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5258: Pass CMAKE_BUILD_TYPE to Impala-lzo
......................................................................
IMPALA-5258: Pass CMAKE_BUILD_TYPE to Impala-lzo
Impala-lzo contained a buffer overrun that was only
present when compiled in optimized mode. To avoid this
(IMPALA-5172), Impala-lzo is only compiled in DEBUG mode.
Since the underlying buffer overrun has been resolved,
reenable passing the CMAKE_BUILD_TYPE down to Impala-lzo.
Change-Id: I190d732a8244dd79bc422cc0c563fb09ba2ed561
Reviewed-on: http://gerrit.cloudera.org:8080/6751
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I190d732a8244dd79bc422cc0c563fb09ba2ed561
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5258: Pass CMAKE BUILD TYPE to Impala-lzo
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5258: Pass CMAKE_BUILD_TYPE to Impala-lzo
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d732a8244dd79bc422cc0c563fb09ba2ed561
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: No