You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by er...@apache.org on 2005/08/28 14:32:54 UTC

svn commit: r263868 - in /directory/shared/kerberos/branches/refactor-to-chain/common: project.xml src/java/org/apache/kerberos/store/operations/GetPrincipal.java

Author: erodriguez
Date: Sun Aug 28 05:32:50 2005
New Revision: 263868

URL: http://svn.apache.org/viewcvs?rev=263868&view=rev
Log:
Better dependency management
o  removed a single logging statement in common code causing a logging dependency
o  removed the logging dependency from the POM

Modified:
    directory/shared/kerberos/branches/refactor-to-chain/common/project.xml
    directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/store/operations/GetPrincipal.java

Modified: directory/shared/kerberos/branches/refactor-to-chain/common/project.xml
URL: http://svn.apache.org/viewcvs/directory/shared/kerberos/branches/refactor-to-chain/common/project.xml?rev=263868&r1=263867&r2=263868&view=diff
==============================================================================
--- directory/shared/kerberos/branches/refactor-to-chain/common/project.xml (original)
+++ directory/shared/kerberos/branches/refactor-to-chain/common/project.xml Sun Aug 28 05:32:50 2005
@@ -11,11 +11,6 @@
   <description>Common Kerberos 5 classes.</description>
   <dependencies>
     <dependency>
-      <groupId>commons-logging</groupId>
-      <artifactId>commons-logging</artifactId>
-      <version>1.0.4</version>
-    </dependency>
-    <dependency>
       <groupId>directory-asn1</groupId>
       <artifactId>asn1-der</artifactId>
       <version>0.3.1</version>

Modified: directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/store/operations/GetPrincipal.java
URL: http://svn.apache.org/viewcvs/directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/store/operations/GetPrincipal.java?rev=263868&r1=263867&r2=263868&view=diff
==============================================================================
--- directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/store/operations/GetPrincipal.java (original)
+++ directory/shared/kerberos/branches/refactor-to-chain/common/src/java/org/apache/kerberos/store/operations/GetPrincipal.java Sun Aug 28 05:32:50 2005
@@ -26,8 +26,6 @@
 import javax.naming.directory.SearchResult;
 import javax.security.auth.kerberos.KerberosPrincipal;
 
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
 import org.apache.kerberos.messages.value.SamType;
 import org.apache.kerberos.store.ContextOperation;
 import org.apache.kerberos.store.KerberosAttribute;
@@ -42,7 +40,6 @@
  */
 public class GetPrincipal implements ContextOperation
 {
-    private final static Log log = LogFactory.getLog( GetPrincipal.class );
     /** The name of the principal to get. */
     private final KerberosPrincipal principal;
 
@@ -139,7 +136,6 @@
         if ( key instanceof String )
         {
             String msg = "JNDI should not return a string for the kerberos key: JNDI property java.naming.ldap.attributes.binary must include the krb5key attribute.";
-            log.error( msg );
             throw new NamingException( msg );
         }