[GitHub] [solr] cpoerschke commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json

[GitBox <gi...@apache.org>]

cpoerschke commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r692331051



##########
File path: solr/core/src/test/org/apache/solr/handler/admin/PropertiesRequestHandlerTest.java
##########
@@ -62,13 +61,9 @@ public void testDisabledRedaction() throws Exception {
 
   @SuppressWarnings({"unchecked"})
   private NamedList<Object> readProperties() throws Exception {
-    String xml = h.query(req(
-        CommonParams.QT, "/admin/properties",
-        CommonParams.WT, "xml"
-    ));
-
-    XMLResponseParser parser = new XMLResponseParser();
-    return (NamedList<Object>)
-        parser.processResponse(new StringReader(xml)).get("system.properties");
+    SolrQueryResponse rsp = new SolrQueryResponse();
+    SolrQueryRequest req = req();
+    new PropertiesRequestHandler().handleRequestBody(req, rsp);

Review comment:
       If we wanted to test the properties handler within the core container then
   
   ```suggestion
       h.getCoreContainer().getInfoHandler().getPropertiesHandler().handleRequestBody(req, rsp);
   ```
   
   could be an alternative here.
   
   The `qt=/admin/properties` previously would indirectly also test accessibility via that path, though I'm not sure how much that is a key part of the test? Or if there is a replacement -- `/admin/info/properties` (?) -- and/or how feasible using that in the test would be ...
   
   What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org