[jira] [Commented] (MAPREDUCE-2630) MR-279: refreshQueues leads to NPEs when used w/FifoScheduler

["Arun C Murthy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059261#comment-13059261 ] 

Arun C Murthy commented on MAPREDUCE-2630:
------------------------------------------

Josh, sorry, took me a while to get to this.

Thanks for the patch.

Could we just add a check to FifoScheduler.reinit ala CS.reinit? That way we can keep a single method in Scheduler. I'm happy to rename it 'configure' or some such. Thoughts?

> MR-279: refreshQueues leads to NPEs when used w/FifoScheduler
> -------------------------------------------------------------
>
>                 Key: MAPREDUCE-2630
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2630
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>         Environment: All
>            Reporter: Josh Wills
>            Priority: Minor
>         Attachments: MAPREDUCE-2630.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The RM's admin service exposes a method refreshQueues that is used to update the queue configuration when used with the CapacityScheduler, but if it is used with the FifoScheduler, it will set the containerTokenSecretManager/clusterTracker fields on the FifoScheduler to null, which eventually leads to NPE. Since the FifoScheduler only has one queue that cannot be refreshed, the correct behavior is for the refreshQueues call to be a no-op.
> I will attach a patch that fixes this by splitting the ResourceScheduler's reinitialize method into separate initialize/updateQueues methods.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira