You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/03 11:29:44 UTC

[GitHub] [airflow] eladkal opened a new issue, #24160: `BigQueryCreateExternalTableOperator` uses deprecated function

eladkal opened a new issue, #24160:
URL: https://github.com/apache/airflow/issues/24160

   ### Body
   
   The `BigQueryCreateExternalTableOperator` uses `create_external_table`:
   
   https://github.com/apache/airflow/blob/cd49a8b9f64c57b5622025baee9247712c692e72/airflow/providers/google/cloud/operators/bigquery.py#L1131-L1147
   
   this function is deprecated:
   https://github.com/apache/airflow/blob/511d0ee256b819690ccf0f6b30d12340b1dd7f0a/airflow/providers/google/cloud/hooks/bigquery.py#L598-L602
   
   **The task:**
   Refactor/change the operator to use `create_empty_table` function so the operator won't raise deprecation warnning.
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] cswpy commented on issue #24160: `BigQueryCreateExternalTableOperator` uses deprecated function

Posted by GitBox <gi...@apache.org>.
cswpy commented on issue #24160:
URL: https://github.com/apache/airflow/issues/24160#issuecomment-1146250054

   Hello @eladkal, I can take this issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] cswpy commented on issue #24160: `BigQueryCreateExternalTableOperator` uses deprecated function

Posted by GitBox <gi...@apache.org>.
cswpy commented on issue #24160:
URL: https://github.com/apache/airflow/issues/24160#issuecomment-1146674808

   Thanks for the tip @potiuk. I will come up with something and submit a PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] cswpy commented on issue #24160: `BigQueryCreateExternalTableOperator` uses deprecated function

Posted by GitBox <gi...@apache.org>.
cswpy commented on issue #24160:
URL: https://github.com/apache/airflow/issues/24160#issuecomment-1146441910

   Thanks for assigning me the task.
   I took a look at the code and I want to make sure that my approach is correct before proceeding. I should create a `table_resouce` (where I would define info relating to the external table) object to pass into the `create_empty_table`? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on issue #24160: `BigQueryCreateExternalTableOperator` uses deprecated function

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #24160:
URL: https://github.com/apache/airflow/issues/24160#issuecomment-1146638481

   I think it's better to discuss with the code and in PR - make a draft PR with your proposal and it can be discussed there - it's far easier this way because the discussion can be focused around the actual code without looking it up and guessing what you really want to do @cswpy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] eladkal closed issue #24160: `BigQueryCreateExternalTableOperator` uses deprecated function

Posted by GitBox <gi...@apache.org>.
eladkal closed issue #24160: `BigQueryCreateExternalTableOperator` uses deprecated function
URL: https://github.com/apache/airflow/issues/24160


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] eladkal commented on issue #24160: `BigQueryCreateExternalTableOperator` uses deprecated function

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #24160:
URL: https://github.com/apache/airflow/issues/24160#issuecomment-1146271751

   @cswpy assigned


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org