[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4151: Support to ignore subdomain when engine pool conditions are met

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #4151:
URL: https://github.com/apache/kyuubi/pull/4151#discussion_r1068841103


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1652,6 +1652,14 @@ object KyuubiConf {
     .checkValues(EngineType.values.map(_.toString))
     .createWithDefault(EngineType.SPARK_SQL.toString)
 
+  val ENGINE_POOL_IGNORE_SUBDOMAIN: ConfigEntry[Boolean] =
+    buildConf("kyuubi.engine.pool.ignoreSubdomain")
+      .doc("Whether to ignore subdomain when engine pool conditions are met.")

Review Comment:
   please replace "subdomain" w/ the full conf key



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org