You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/04 18:31:06 UTC
[GitHub] [incubator-nuttx] davids5 opened a new issue #1511: Commit 60fe0a0f96613e7bc9ce5c6bb018f48638ca69f1 broke c++ builds.
davids5 opened a new issue #1511:
URL: https://github.com/apache/incubator-nuttx/issues/1511
There was an unintentional side effect of 60fe0a0f96613e7bc9ce5c6bb018f48638ca69f1
The very common variable name index can not be use with this change,
```
c ../../src/drivers/uavcan/libuavcan/libuavcan/src/node/uc_service_client.cpp
In file included from ../../src/drivers/uavcan/libuavcan/./libuavcan/include/uavcan/node/service_client.hpp:9,
from ../../src/drivers/uavcan/libuavcan/libuavcan/src/node/uc_service_client.cpp:5:
../../src/drivers/uavcan/libuavcan/./libuavcan/include/uavcan/util/multiset.hpp:145:33: error: macro "index" requires 2 arguments, but only 1 given
145 | : index(target_index)
``` | ^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 closed issue #1511: Commit 60fe0a0f96613e7bc9ce5c6bb018f48638ca69f1 broke c++ builds.
Posted by GitBox <gi...@apache.org>.
davids5 closed issue #1511:
URL: https://github.com/apache/incubator-nuttx/issues/1511
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on issue #1511: Commit 60fe0a0f96613e7bc9ce5c6bb018f48638ca69f1 broke c++ builds.
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #1511:
URL: https://github.com/apache/incubator-nuttx/issues/1511#issuecomment-668779127
Do you mean fix the api so that they are functions or just delete the macros?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #1511: Commit 60fe0a0f96613e7bc9ce5c6bb018f48638ca69f1 broke c++ builds.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #1511:
URL: https://github.com/apache/incubator-nuttx/issues/1511#issuecomment-668771454
Should we remove these two macros?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org